Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp3672763imm; Mon, 10 Sep 2018 23:34:05 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYY3zNJBZNp3061OiXFqep1zKoDkrUGemFaR+YH3uMp70XO4qf0zIVRJE+w6ps9cFQWBPUO X-Received: by 2002:a17:902:a58c:: with SMTP id az12-v6mr25497583plb.339.1536647645097; Mon, 10 Sep 2018 23:34:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536647645; cv=none; d=google.com; s=arc-20160816; b=fojpN3jipCzLGxxFlCGyT+4FifeJRC15se9SRrDGdLeRwEy7HcnDwBgup+4dSyOcgy ZRT2gea8LddWU4EaR4Us8OOltw0ivXPqLzolyDeQMPFrkLl7FvVDfNUbHLjZ342Vet0T JgfQAyuMQwUGc81EjaDUU5KZRvdPa/GKiWMzaRBnudD1Hqps+Z5VXIrwZ5t0wHfgs3Cb ZZbkkTwCsdNv7wAQhuJfDdP9YdskBhZMVcJ5saLfSKY1nZ6Ny7kkOlysL7+4UvURefjf 86iQRrov8Cb1adjXxq6aQAQUe5XVwJBjWWl6WADSJWtKNYDLp0XZJb8/diAt7fd8oFNE EEiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=7A8dWqZJ1JVbq+EWXqvi0esbNRltwavXgahwOc+/Lnk=; b=sQz+i1Li2McThU4+mg88r2xXyIwR5S4q+Q38QKITzf0naZp44miSRWY6sQTzYAYv2E SOaug/sTuNGuui4uTqCcE5VDQaOLaf4hXddLjRgEk/50TeyDYtrLC/mn0MO0LsyJFGfx 372IrP+SqYJmllnB0CNabYPfPFAUM3RG4CNzpGoZtC+85Ag6IJ2DKQ4QkBGpmkh/BrEl naWbRNJNQfFGumLadsLnkFsRHfsgKmnNUs2hZVWT1LBXD/Td39tupQ0M9nuINBNCA+RT F/lGEF//ZpHKAJkNEmKwb9yAUN6wz0oeCBzDqk1vjhjZGjsuFoLYSH5pH7SmfLWxRrBa 7SnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=ODv27x2s; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c1-v6si20454959pli.497.2018.09.10.23.33.47; Mon, 10 Sep 2018 23:34:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=ODv27x2s; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727009AbeIKLbY (ORCPT + 99 others); Tue, 11 Sep 2018 07:31:24 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:34752 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726429AbeIKLbY (ORCPT ); Tue, 11 Sep 2018 07:31:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=7A8dWqZJ1JVbq+EWXqvi0esbNRltwavXgahwOc+/Lnk=; b=ODv27x2sCP/xvtDR0X1lwjzrW foTUtHbk2BmyeVRjSWev4Rb78ia0/U7ouEDaO2suZTVfjv7xMkln3Dg3/OOllonzyg3KQ7GjMq00W Oejg5070PcMgZtCEaknarqlnrXvp2IokjbRxeTCxLH7EeE51fiXe5vumGimabkJBMzDUwv03LLa8H y2Z7Cyz9bQyA2Plk4cz//kZajnu8MoD00Ab9S7cxf4uaAnJL6c10+wTdGt2nR1GwFQf6w5EobePcB yZW5sTNk8utliqNPdc3XPrl8bycSP51+RUQCXMrLzvtE5ceSeapPC65xT2is1yP2nhYzdYnRpj2tK El/13zfng==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fzcEy-0002Ut-3m; Tue, 11 Sep 2018 06:33:36 +0000 Date: Mon, 10 Sep 2018 23:33:35 -0700 From: Christoph Hellwig To: Miklos Szeredi Cc: Christoph Hellwig , syzbot , bcrl , linux-aio , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs , Al Viro , Andrea Arcangeli , Andrew Morton Subject: Re: possible deadlock in aio_poll Message-ID: <20180911063335.GA3315@infradead.org> References: <000000000000cbb35d05757f7a3a@google.com> <20180910165317.GA3237@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 10, 2018 at 08:14:20PM +0200, Miklos Szeredi wrote: > Why do pollable waitqueues need to disable interrupts generally? Any waitqueue needs to disable interrupts for consistency. We always use spin_lock_irqsave in __wake_up_common_lock() for example.