Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp3720107imm; Tue, 11 Sep 2018 00:35:06 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYgL/dBUe9CWYW5yW8SCv9mGaOfzWFhGYIfRUX3oYC5mM3jhWbCgx/bxVxu0NlkJM8qXiZH X-Received: by 2002:a63:e841:: with SMTP id a1-v6mr26393907pgk.126.1536651306445; Tue, 11 Sep 2018 00:35:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536651306; cv=none; d=google.com; s=arc-20160816; b=BvsH5qIKQJvmOaufvz5aOIOsdpPwEhSIq9vaZQnKhCUWPy9Zvm5Olj5y6fcBsh7tOL e6gbRzr4LTM/VTs9CxQMT/VFmorPSMdwXOlpHsq+28o0gU0n7b+T9hs/hei0WtGRA2T6 vLtiHxEk4lHVlNUFqr/7wGtfb++wCFdWFN44qSaGxV8cwp2+1ZZCr15jpd02hphI5I+0 ARDMWMDgi4GXLaMxsU3N0jRnlqIezhsv464JzNBQZgTVyDI3ZxfHqb4e9qrYqqFgmv4M WS0nFKiDvIHUNGCZIxFdxIlET9Z6x9Nnk/Ub7fSDmKnvAwoQ9C4XTC30oG8pEoVMnQA4 qtcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature; bh=GQoWPqbfqOFb0F1rWXeI46EOiKsH46LnXSKEVSaW3Oo=; b=QsRevEP0CqBSPuh0cJahludJsPiuUgQv6kO92sjCXYNEHppT65xKzvOR5L2z7HZlMB V/DsXP9D3WpVt6y4bFffPex74RXnw/0lZvkNXwC8LlAYrkbLRo5TMyJz/1ygF7FgNaCx 7HBiLGE/asAhfif99DG5/36tKaP5erkFBRGclvPVMddvbY+9CYmkwr5GUhX2vOUiXBl3 xX9kdRkXwMrkXSLtjRE8zxBuw+ZETFRjaYc82+SxbrucQ8l8UEA9NsgUu6b+mPQgMVjL BB6uBeO62KwdrafiruV8rY0HNIi0EUoio9azfcl66R6NKfLzaqeqOyOHbn34IPb6QNL7 eATQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@ffwll.ch header.s=google header.b=TwOhGWZi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h14-v6si20514735pgl.289.2018.09.11.00.34.51; Tue, 11 Sep 2018 00:35:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@ffwll.ch header.s=google header.b=TwOhGWZi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726798AbeIKMcm (ORCPT + 99 others); Tue, 11 Sep 2018 08:32:42 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:45719 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726353AbeIKMcm (ORCPT ); Tue, 11 Sep 2018 08:32:42 -0400 Received: by mail-ed1-f68.google.com with SMTP id p52-v6so18407511eda.12 for ; Tue, 11 Sep 2018 00:34:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=GQoWPqbfqOFb0F1rWXeI46EOiKsH46LnXSKEVSaW3Oo=; b=TwOhGWZijh92DhqY6h5dNEzNJ4fFNHtuoas3NxA3tJqQuHj32O6bKgL3eabcOqTAD9 uwCQM1hvtihHFN5caK1U+8UOQyFDZ4J3apiTdasf/GY3MVpzX0oh0YFbmuA9dzv312DM kbFiEbkCs10KVOAXWtKOB9PLXMi3r9EGiXZC0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=GQoWPqbfqOFb0F1rWXeI46EOiKsH46LnXSKEVSaW3Oo=; b=P6Ups7fqqjxz8wEKJZGwdhpbifXnDQwfz9w1a6yFh05KE0IHxGiiokQs0ihVWOk3WC 6HIssWDpL7LAyKRKyKYM5vM/XYm2LUogpOk2odp/tHVW+7u0faERqj6EXhsMME8ZI8Go 4CYGngmgrTJo2YuBDW/+t13uDQQV9+OPEPzjplnPSo/Kk+oSMZYcjgeq1AZkKCTgnVH8 15DDMXzrOfQQ2IiddGCNts8zvWV2uKBHXqq+dMAXfnr+OG+9A74Utlsr6iYSUkqlf0eJ Wal0SwHKOChyC0V3d3Vh5MO8yrU+9HDZsJg9y6jhSuQb6KzB+LKpIoQAZK4lqKoYaegG I72Q== X-Gm-Message-State: APzg51D7GieS3J/I6LqVYxdvJsZiPkS6oxFA/5LI4ffiMLBmxojxxSVA PYhHxNzkHvEpJukP1w+xZSXw1Q== X-Received: by 2002:a50:a38a:: with SMTP id s10-v6mr25598214edb.99.1536651281557; Tue, 11 Sep 2018 00:34:41 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id w20-v6sm18874627edc.12.2018.09.11.00.34.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Sep 2018 00:34:40 -0700 (PDT) Date: Tue, 11 Sep 2018 09:34:39 +0200 From: Daniel Vetter To: YueHaibing Cc: Gustavo Padovan , Maarten Lankhorst , Sean Paul , David Airlie , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH -next] drm: Remove set but not used variable 'config' Message-ID: <20180911073438.GG19774@phenom.ffwll.local> Mail-Followup-To: YueHaibing , Gustavo Padovan , Maarten Lankhorst , Sean Paul , David Airlie , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <1536646814-186429-1-git-send-email-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1536646814-186429-1-git-send-email-yuehaibing@huawei.com> X-Operating-System: Linux phenom 4.14.0-3-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 11, 2018 at 06:20:14AM +0000, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/drm_plane.c: In function 'drm_mode_getplane_res': > drivers/gpu/drm/drm_plane.c:475:26: warning: > variable 'config' set but not used [-Wunused-but-set-variable] > > Signed-off-by: YueHaibing Applied, thanks. -Daniel > --- > drivers/gpu/drm/drm_plane.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c > index 36bf3fe..4a72c68 100644 > --- a/drivers/gpu/drm/drm_plane.c > +++ b/drivers/gpu/drm/drm_plane.c > @@ -472,7 +472,6 @@ int drm_mode_getplane_res(struct drm_device *dev, void *data, > struct drm_file *file_priv) > { > struct drm_mode_get_plane_res *plane_resp = data; > - struct drm_mode_config *config; > struct drm_plane *plane; > uint32_t __user *plane_ptr; > int count = 0; > @@ -480,7 +479,6 @@ int drm_mode_getplane_res(struct drm_device *dev, void *data, > if (!drm_core_check_feature(dev, DRIVER_MODESET)) > return -EINVAL; > > - config = &dev->mode_config; > plane_ptr = u64_to_user_ptr(plane_resp->plane_id_ptr); > > /* > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch