Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp3726195imm; Tue, 11 Sep 2018 00:43:15 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdb8cqFmDu/lIW4OBe5cXi1nkG5O7kz1qJTteVxiGZE5bnKsTuY77pIiUMwYNkGffQdKvNFZ X-Received: by 2002:a17:902:6909:: with SMTP id j9-v6mr25780365plk.196.1536651794999; Tue, 11 Sep 2018 00:43:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536651794; cv=none; d=google.com; s=arc-20160816; b=wzrWHEEV+RNANC7Oylhj7Y0F+LoVe+7Qi+h5v+7+LxndYm7L4POitYxMGn/7Zl3B8B bZ8UPa8veOXBPUwtgefZGlirsozapZq/Dp3tkJjc48WvRh0Ntd9prtWe8qzo8FxgnJjM 4mx64939AlQCY9MBu6fAw1qu/89z9g/1XFpMyCZYZwyLpbq7g678AR0nKJWoEmw687z6 4ttYfpMcfaBg50LRX8DLvXQ3uyEj7lcvdr/uYMoajsqDlBVnAnRk0nCx2IzfT14nDLnu fnmCfWUaYP6x9p2Ur7ObeSd0ZmdC0qKYeXwT/gau5EU5ggikYdDcDFI2No1aYr2DG22q 81YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=nGHc63cH2nU9hznmq5pyykCU8sCgnMVDp8VTGJFwh7A=; b=IuBAR2UI8T9pnI0GqSCrOegSOBLVqJm0T+em92MKnDTb9a5hTOHZlrWp7WCyQg9nOg G3R4SjmT9t4slmbwxzIVBERH9dwTw15A1a3dw53/Ljzm8qBQCfAFNh1r8lRCT83qmeEa gqNmnbnaT1Zo/UVtUnrXns6TI94JTAjFbWEfQLmYkSEVp63YS5ZJ48cXROTT5I5VXQLj 56L/JOeMeEUvStOcBiSNaJcNItX3VjcoTx3vH6LkcffZ5D/5giMOFtrBnJBYmLsPG8jJ SYFmUkFMcgDRXZG7VbddXwXX+J8WwtvXHjoFKQlsyB18JBF1Yq67RHHxz4zbbbl3BrvX zMfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JNYOXajp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a13-v6si19397367pgj.495.2018.09.11.00.43.00; Tue, 11 Sep 2018 00:43:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JNYOXajp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726622AbeIKMjf (ORCPT + 99 others); Tue, 11 Sep 2018 08:39:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:39974 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726325AbeIKMjf (ORCPT ); Tue, 11 Sep 2018 08:39:35 -0400 Received: from localhost (unknown [171.76.126.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC04C20865; Tue, 11 Sep 2018 07:41:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1536651693; bh=zVXVupPeMtn2zez/1jKCHfcQ4XWjrhgai04j6vKm1Zc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JNYOXajpDmU0CEL5KDMX6x4IqUwkWEog8X1lKF5k1PpT5OIU8HCs1Xbztpa2TlQq+ pRgC1Y0HDTCzoSnUYRLmrTIXuF/dnAe8X1BgUETmRchZ5nz9piF8h9cGrEjLWggEOo R0BGCVoly0xhdXxYgYwtoWF+DCubluCrF52/OtCc= Date: Tue, 11 Sep 2018 13:11:22 +0530 From: Vinod To: Radhey Shyam Pandey Cc: "dan.j.williams@intel.com" , Michal Simek , Appana Durga Kedareswara Rao , "lars@metafoo.de" , "dmaengine@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 3/3] dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer Message-ID: <20180911074122.GM2634@vkoul-mobl> References: <1532688639-32230-1-git-send-email-radhey.shyam.pandey@xilinx.com> <1532688639-32230-4-git-send-email-radhey.shyam.pandey@xilinx.com> <20180821155553.GI2388@vkoul-mobl> <20180829040111.GD2388@vkoul-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07-09-18, 12:08, Radhey Shyam Pandey wrote: > > > Yeah that part was clear but the implementation can be better.. > I thought over it and it seems having a new interface dma_ctrl_write_64 > taking lsb and msb bits input looks better and scalable. It will be similar > to existing vdma_desc_write_64 impl. I will send v2 if it looks ok. Yes that is much better, btw why not reuse same routine as common xilinx lib functions :) -- ~Vinod