Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp3727782imm; Tue, 11 Sep 2018 00:45:26 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdbfpo0kNr0S9aiNszsdybE8vL6HUkH+clWIc/2jK3qXzbUzqBTKVOfc1kkEn4kJPQp4Ln7t X-Received: by 2002:a62:4808:: with SMTP id v8-v6mr28125367pfa.89.1536651926918; Tue, 11 Sep 2018 00:45:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536651926; cv=none; d=google.com; s=arc-20160816; b=AvFd1cEs05a8YS/jyN0/yC2qZefx+GVMpd8vfP8oOuidc04sKOHG34+sqT5VVC1QLN BbnH1kEDV7Tot/fanBRWgUkx/fYy1iZmj3PfN/xVMDTeh7r2xUBmoXjcHO/PrgW/DPRq D/8vNdRzp4DPhKh4yW3VUtzCP8JfQWVXhK9nEXTtwChBuXIGiFQyAuag9acCLUKfUwC5 WIhsnlpodxYL6N7UbjX/KAzbcHqwedDIsFRHsnDA04x9U6uNtM4WGPz8o6E7BQWGIR24 phIkuYo7YVEWwdeScSBkVmg0YS+RFyv5EetYVN9OAAjGOhpom3xgZlSuK2fBbLiRFQ71 P72g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=n7GihUKMg6Viq0D80bqZfiF1LlNLcKfT2OyCREz2LYI=; b=CmQVHzVINOhc0r2AsUBF5Re0hWSTOom7WUw+U/l8pm7BWScsLM7DdNQzE2wiq1TSUa FS+zzf1xgv+FWxsv3do5FY96GHGeusDMBMer5XeCaoaTojyBjg9bTd9Qf4a9OPgDSZFA yjVUyWeFwNKUN1M+3yBjMXCzfBbbt+e4UxEp2yfUU/5GccVDdmQw+V88JitjmzYUDp6X VvA5b5yyWFawguutkS/kJL4Sgk/Ag8rlVjn7CrgeATYdH2Rpi+3hHjuHXbKxQp2d56VP c2Q5WraQ5ctfgWBGm9Mw012SCSma3SIZ6PA35pvgKJfIaJfbGifQOZPJYD9h1k8UXaYT Zf6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=W6TwYVeZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t32-v6si20538311pgk.294.2018.09.11.00.45.12; Tue, 11 Sep 2018 00:45:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=W6TwYVeZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726798AbeIKMmy (ORCPT + 99 others); Tue, 11 Sep 2018 08:42:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:41774 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726482AbeIKMmy (ORCPT ); Tue, 11 Sep 2018 08:42:54 -0400 Received: from localhost (unknown [171.76.126.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3D82620839; Tue, 11 Sep 2018 07:44:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1536651892; bh=jas5CSfN/5hP8JPc0IfjBmGCI677S/tTPp2O2scbva8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W6TwYVeZtG9yAe/atSXqvExdkMA20iq+tuyth1Wo2ZPjbon/8tqIM/C+pQHOOsvC+ R1SK/VA5IkVnDEI0dOwdCD8WslFrSQkOJyzCzsO6tj7+hcsqFfILiJO/COfYniWoim 6YbpnuQlCaovORIg7KNqpt/For7B8+9eEofQJzQA= Date: Tue, 11 Sep 2018 13:14:42 +0530 From: Vinod To: Zhaoxiong Yuan Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dma: idma64: replace spin_lock_irqsave with spin_lock Message-ID: <20180911074442.GN2634@vkoul-mobl> References: <1536346930-6842-1-git-send-email-yuanzhx326@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1536346930-6842-1-git-send-email-yuanzhx326@gmail.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08-09-18, 06:02, Zhaoxiong Yuan wrote: > idma64_chan_irq() is invoked in hardirq handle function, it is unnecessary > to call spin_lock_irqsave. Please add a line after log and s-o-b I have applied after doing above and fixing subsystem tag (dmaengine) -- ~Vinod