Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S264176AbTKKBUn (ORCPT <rfc822;willy@w.ods.org>);
	Mon, 10 Nov 2003 20:20:43 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264178AbTKKBUn
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 10 Nov 2003 20:20:43 -0500
Received: from mail-09.iinet.net.au ([203.59.3.41]:205 "HELO mail.iinet.net.au")
	by vger.kernel.org with SMTP id S264176AbTKKBUm (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 10 Nov 2003 20:20:42 -0500
Message-ID: <3FB03948.7090203@cyberone.com.au>
Date: Tue, 11 Nov 2003 12:20:08 +1100
From: Nick Piggin <piggin@cyberone.com.au>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030827 Debian/1.4-3
X-Accept-Language: en
MIME-Version: 1.0
To: Andrew Morton <akpm@osdl.org>
CC: =?ISO-8859-1?Q?Ram=F3n_Rey_Vicente?= <ramon.rey@hispalinux.es>,
       linux-kernel@vger.kernel.org
Subject: Re: [2.6.0-test9-mm2] Badness in as_put_request at drivers/block/as-iosched.c:1783
References: <1068500134.2060.3.camel@debian> <20031110140451.2b5db433.akpm@osdl.org>
In-Reply-To: <20031110140451.2b5db433.akpm@osdl.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1349
Lines: 46



Andrew Morton wrote:

>Ram?n Rey Vicente <ramon.rey@hispalinux.es> wrote:
>
>>Hi.
>>
>>Trying to scan de ide-scsi devices of my system, I get this
>>
>>arq->state 4
>>Badness in as_put_request at drivers/block/as-iosched.c:1783
>>Call Trace:
>> [<c01dc908>] as_put_request+0x48/0xa0
>> [<c01d47d3>] elv_put_request+0x13/0x20
>> [<c01d69f2>] __blk_put_request+0x52/0xa0
>> [<c01d6a61>] blk_put_request+0x21/0x40
>> [<c01d9d0e>] sg_io+0x2ee/0x440
>> [<c01da5c0>] scsi_cmd_ioctl+0x3c0/0x480
>> [<c0124b49>] update_process_times+0x29/0x40
>> [<c011949c>] schedule+0x31c/0x620
>> [<d093bb65>] cdrom_ioctl+0x25/0xd60 [cdrom]
>> [<c012eb33>] do_clock_nanosleep+0x1b3/0x300
>> [<c0119800>] default_wake_function+0x0/0x20
>> [<c01d86fa>] blkdev_ioctl+0x7a/0x383
>> [<c01584be>] block_ioctl+0x1e/0x40
>> [<c016158f>] sys_ioctl+0xef/0x260
>> [<c0257c57>] syscall_call+0x7/0xb
>>
>
>It looks to me that a simple set_request()/put_request() will always do
>this.
>
>Nick?
>

Yes. I suppose just add a check for PRESCHED there as well. This
actually can happen in ll_rw_blk.c as well and its pretty hard to
change.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/