Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp3741164imm; Tue, 11 Sep 2018 01:02:51 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYKptStlmZw4brI8tMJrfr1qyv/gMlrfyFh3GuiJoZy9pFtREBGKx4zgMzLzwtX7joAvJLt X-Received: by 2002:a62:384a:: with SMTP id f71-v6mr28095318pfa.48.1536652971237; Tue, 11 Sep 2018 01:02:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536652971; cv=none; d=google.com; s=arc-20160816; b=Gn6+Z/QtaRD11FcFsjKXRDjyXicGKIhR2kluB8fZi0esooLtOQ9e3+HhT1YxBxL+Y/ 0NBbEQMHqoyUBkdKut7OM6t6g4YPFlFmKEc9IglLkeGEZ2PRush7WvhNjYd/Npd0B6HB DXyhT0DvjbEWdflONCg5Qnd9mW/I7wotT6fwRbESW6lqETRSY4pzoTQ9jf4sNbXW6uiv 4gumfuSi860rInhn3BtPrB4UOhyaide32SZwOlnepA7kPO9gpuyPiiSYQSrmdx2EnZgA FxxhKDCycymoV4/er8PBbMhm6LaFpQhJOIw68JNdkMQVuconpVf1sx1cHuapr9lN0Ea3 7gkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=l8ydBzzEiuMOo7iaoXHLn0/IjewdtMcQpi9yRGG5gZE=; b=b8llLyFr+t9r4Q+HPGQtjRzJPHzovYh8QrKKR/KDN2zAgR5ah41J95lbucrRVDmVs9 CeknK70b4C5CxUvn/lK/H6GSyOlYxCK+YM0UiTPybewrl1GKJERhbNRmDFaT/383dHLu 71+OFVA2AKAK3hqdiLv1UliWjiz1/cAUYRndX+eIymMM1Gng8Qfy/0/sm048xqUWe8Eo 286WMNsA2nzUbb+8Pjka4v7iQrDlGrpYXShTRCgLkOrkbD28n1+8fir4W9E/hagVdrBa 92tzi4lAYQNjuyecJOmtFqSu7+iS7KK5ClQCIzF18Bg8gZkalfoiWoUG0AzSocGqUT1S CqXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j124-v6si21807154pfb.191.2018.09.11.01.02.34; Tue, 11 Sep 2018 01:02:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727181AbeIKM7G (ORCPT + 99 others); Tue, 11 Sep 2018 08:59:06 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:41092 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726554AbeIKM7G (ORCPT ); Tue, 11 Sep 2018 08:59:06 -0400 Received: from bigeasy by Galois.linutronix.de with local (Exim 4.80) (envelope-from ) id 1fzdbI-0000h6-DS; Tue, 11 Sep 2018 10:00:44 +0200 Date: Tue, 11 Sep 2018 10:00:44 +0200 From: Sebastian Andrzej Siewior To: Jia-Ju Bai Cc: gregkh@linuxfoundation.org, johan@kernel.org, bjorn@mork.no, mingo@kernel.org, oneukum@suse.com, viro@zeniv.linux.org.uk, mark.rutland@arm.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] Revert "usb: cdc-wdm: Fix a sleep-in-atomic-context bug in service_outstanding_interrupt()" Message-ID: <20180911080044.ufe6mvspupckf5ob@linutronix.de> References: <20180901081210.16655-1-baijiaju1990@gmail.com> <20180911074930.2g6ryk7qe46cijhi@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180911074930.2g6ryk7qe46cijhi@linutronix.de> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit 6e22e3af7bb3a7b9dc53cb4687659f6e63fca427. The bug the patch describes to, has been already fixed in commit 2df6948428542 ("USB: cdc-wdm: don't enable interrupts in USB-giveback") so need to this, revert it. Signed-off-by: Sebastian Andrzej Siewior --- drivers/usb/class/cdc-wdm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c index 656d247819c9d..bec581fb7c636 100644 --- a/drivers/usb/class/cdc-wdm.c +++ b/drivers/usb/class/cdc-wdm.c @@ -460,7 +460,7 @@ static int service_outstanding_interrupt(struct wdm_device *desc) set_bit(WDM_RESPONDING, &desc->flags); spin_unlock_irq(&desc->iuspin); - rv = usb_submit_urb(desc->response, GFP_ATOMIC); + rv = usb_submit_urb(desc->response, GFP_KERNEL); spin_lock_irq(&desc->iuspin); if (rv) { dev_err(&desc->intf->dev, -- 2.19.0.rc2