Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 11 Sep 2018 15:15:48 +0300
From:   Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Dou Liyang <douly.fnst@cn.fujitsu.com>,
        Pasha Tatashin <Pavel.Tatashin@microsoft.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] Revert "x86/tsc: Consolidate init code"
Message-ID: <20180911121548.GW5565@intel.com>
References: <20180910121925.27682-1-ville.syrjala@linux.intel.com>
 <alpine.DEB.2.21.1809101443290.1292@nanos.tec.linutronix.de>
 <20180910140710.GR5565@intel.com>
 <alpine.DEB.2.21.1809101846160.1419@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <alpine.DEB.2.21.1809101846160.1419@nanos.tec.linutronix.de>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Sep 10, 2018 at 06:53:54PM +0200, Thomas Gleixner wrote:
> On Mon, 10 Sep 2018, Ville Syrj?l? wrote:
> 
> Good: 1718674.70 BogoMIPS (lpj=2863311530)
> Bad:   859455.59 BogoMIPS (lpj=1431852151)
> 
> while both kernels agree on the CPU frequency of 996MHz. This pretty much
> smells like the 32bit LPJ conversion bug which got fixed in rc3. Does the
> problem persist with rc3?

Indeed looks to be fixed by commit 17f6bac22493 ("x86/tsc:
Prevent result truncation on 32bit"). I both cherry-picked that
on top of rc2 to make sure it really is that commit, and also
tested plain rc3 to make sure it still works.

And comparing the bogomips between the three relevant commits makes
the bug pretty obvious in hindsight:
Calibrating delay loop (skipped), value calculated using timer frequency.. 1718674.70 BogoMIPS (lpj=2863311530)
Calibrating delay loop (skipped), value calculated using timer frequency.. 859455.59 BogoMIPS (lpj=1431852151)
Calibrating delay loop (skipped), value calculated using timer frequency.. 1994.50 BogoMIPS (lpj=3322410)

I suppose we just got very lucky with older kernels.

-- 
Ville Syrj?l?
Intel