Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 1/2] dmaengine: Add metadata_ops for
 dma_async_tx_descriptor
To:     Vinod <vkoul@kernel.org>
CC:     <dan.j.williams@intel.com>, <dmaengine@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <lars@metafoo.de>,
        <radheys@xilinx.com>
References: <20180830121910.16005-1-peter.ujfalusi@ti.com>
 <20180830121910.16005-2-peter.ujfalusi@ti.com>
 <20180911073307.GK2634@vkoul-mobl>
From:   Peter Ujfalusi <peter.ujfalusi@ti.com>
Message-ID: <6ba92876-899f-5bf2-e494-259e1e680750@ti.com>
Date:   Tue, 11 Sep 2018 15:33:51 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180911073307.GK2634@vkoul-mobl>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Vinod,

On 2018-09-11 10:33, Vinod wrote:
>> +int dmaengine_desc_attach_metadata(struct dma_async_tx_descriptor *desc,
>> +				   void *data, size_t len)
>> +{
>> +	int ret;
>> +
>> +	if (!desc)
>> +		return -EINVAL;
>> +
>> +	ret = desc_check_and_set_metadata_mode(desc, DESC_METADATA_CLIENT);
>> +	if (ret)
>> +		return ret;
>> +
>> +	if (!desc->metadata_ops || !desc->metadata_ops->attach)
>> +		return -ENOTSUPP;
>> +
>> +	return desc->metadata_ops->attach(desc, data, len);
>> +}
>> +EXPORT_SYMBOL(dmaengine_desc_attach_metadata);
> 
> EXPORT_SYMBOL_GPL ?

Sure, I think I have looked at
dma_async_tx_descriptor_init/dmaengine_get_unmap_data/dma_issue_pending_all/etc
they have EXPORT_SYMBOL()

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki