Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp4101069imm; Tue, 11 Sep 2018 07:01:42 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaQSuySDU+1hWzjuB6+HKXBd7SgZOZxVzeGhrTh0Ox2ksNHEVQzu6nEJMUrAG70tEpVhYhX X-Received: by 2002:a17:902:ba86:: with SMTP id k6-v6mr27748075pls.84.1536674502007; Tue, 11 Sep 2018 07:01:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536674501; cv=none; d=google.com; s=arc-20160816; b=uSsBXMJQtdTgNd+nuGWsBX6vVODCJOw0jXFeEgKtbD4Rkf8exl4sZ3pK1qlnZreXXo soetz3mh+646P/tBQu2mjaPOp6sZiLGgDUPtKH2FRTWy1IpguvpttTynBkYDdLlFSk8B nRc+/eVfokgpBFvPTUkhNB6w4a1XvA7dNpyA6QyMl7jVni9QXRzwsHvavDNiNTcamCn+ i+XuOIjpjZXliTMYhkZ53oL3WdpqWwjrMBIYC0DtWsLzDyoikwK3qZGhJewkXlVnS1zZ n4m6reGtrTpQ+Fz6a57B1YHeCoZ/P9soAFY0Ll0alB6pBMQJDFpEVSwGcKqSCxspo2Nr 4BBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=OyH98qt2uwrISq7HZ2FsLx6ueFs7I86Trpl3rfvjkJ8=; b=ozCMnR6j1QH2+6Oro/OfK5UNW2Z9+qOVxH6wclZZ86JfoS5oiPXyzc3A0KLTtIMzsh m4Kvh2Y+LODaDNPMylsg6gBThwakzy1TdibzyYi2OWMMAW7cf47a2AQNP39JvG5vwCkg qO3M7qFMKUP8NAQySDy6nh6yAkBu3jVbddmGYATnmovpr4N7OFcfVPiCZc2QvlLWVJKu fLc6ZimRad/7PiTQH0jVAzs3XuR7vRlhSlvLci3UMLai46kjQCGQCdqjBbigx2QabTeU OgodZxlGeTfYVdasYCGSA4AcSYt2AGeI/3MvwunQ3VLYh8LRyKYRsA6FQhzezV9GPIJu 2tEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VQbjDnwR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o18-v6si20625757pgn.190.2018.09.11.07.01.21; Tue, 11 Sep 2018 07:01:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VQbjDnwR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727818AbeIKTAD (ORCPT + 99 others); Tue, 11 Sep 2018 15:00:03 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:38223 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727642AbeIKTAD (ORCPT ); Tue, 11 Sep 2018 15:00:03 -0400 Received: by mail-wm0-f68.google.com with SMTP id t25-v6so1112488wmi.3 for ; Tue, 11 Sep 2018 07:00:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=OyH98qt2uwrISq7HZ2FsLx6ueFs7I86Trpl3rfvjkJ8=; b=VQbjDnwRQwlyttIhgtrtTHFlRZY5I25klHc2MD9I+AWtxlI+TsjVbxAq/HQpstIXlO 6B5sDX4txb0r/SWzZcIEPMQsugZq4qXZoCk6A2h3jeTl+8IvZVkif5m/FE3+N1Q9HyOp ubo37D5IuP8qQPw1O9Es8ML8zHoO5XsG5V+Zk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=OyH98qt2uwrISq7HZ2FsLx6ueFs7I86Trpl3rfvjkJ8=; b=axqLJqZr2OcUYxPd7zmnAS+pRDh4LUYazr2HwMLjyOxgLMWN+x8nCtS/I5vFGkgeZz HO5bDnvgX/w0l6FKqYPC//3pDPINJty8ktPzqzrc042wY7SUZNVtl0TbTGImbMutC73t QD8dfTuBaq3sO6XTywaM1LTaONez+DzClKPogCkFJnH+UAlCTH/ZxgMNfwX/dMsJ53Ko Ykq0HDtFpROYF/B8c6kg4pWj5/muC1wbo/aJEh7hsWOY+vk4ZuNqVn+9JBcaoPLiFmWi eGkPR2prlvpXmVFDy+LmEJPimDcC7dLV0CjiUcgeInpz577feTuGSQznTmFL8XF6RXtT Ua9Q== X-Gm-Message-State: APzg51B0M8PV8g7ltD+iR6bKtGwwKsQPY1dniusRhn1Jd+4Nc93mfN7x pq0gr63nr/AlE+6bQ+886pGjzA== X-Received: by 2002:a1c:65c5:: with SMTP id z188-v6mr1412795wmb.57.1536674433951; Tue, 11 Sep 2018 07:00:33 -0700 (PDT) Received: from dell ([2.27.167.7]) by smtp.gmail.com with ESMTPSA id j2-v6sm1787523wmj.5.2018.09.11.07.00.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Sep 2018 07:00:32 -0700 (PDT) Date: Tue, 11 Sep 2018 15:00:31 +0100 From: Lee Jones To: Colin King Cc: patches@opensource.cirrus.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: arizona: make array mclk_name static, shrinks object size Message-ID: <20180911140031.GT4185@dell> References: <20180904141553.28000-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180904141553.28000-1-colin.king@canonical.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 04 Sep 2018, Colin King wrote: > From: Colin Ian King > > Don't populate the array mclk_name on the stack but instead make it > static. Makes the object code smaller by 23 bytes: > > Before: > text data bss dec hex filename > 38050 11604 64 49718 c236 linux/drivers/mfd/arizona-core.o > > After: > text data bss dec hex filename > 38027 11604 64 49695 c21f linux/drivers/mfd/arizona-core.o > > (gcc version 8.2.0 x86_64) > > Signed-off-by: Colin Ian King > --- > drivers/mfd/arizona-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog