Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH v3] usb: typec: get the vbus source and charge values from the devicetree
From:   Guenter Roeck <groeck7@gmail.com>
In-Reply-To: <20180911145931.32441-1-angus@akkea.ca>
Date:   Tue, 11 Sep 2018 08:33:22 -0700
Cc:     Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <8A418EC6-62A4-4354-8928-7693696409D1@gmail.com>
References: <20180906192644.24587-1-angus@akkea.ca> <20180911145931.32441-1-angus@akkea.ca>
To:     "Angus Ainslie (Purism)" <angus@akkea.ca>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

I cant put my finger on it but this seems wrong. As i said both src and sink=
 should never be true at the same time. I also din=E2=80=99t understand why t=
urning off src should power off your board. Ultimately my concern is that we=
 may be just painting over the real problem, and that would be really bad to=
 do with dt properties.

Note that sending to groeck7@ makes it hard for me to see your emails and to=
 reply. Using linux@roeck-us.net would be much better.

Guenter

Sent from my iPhone

> On Sep 11, 2018, at 7:59 AM, Angus Ainslie (Purism) <angus@akkea.ca> wrote=
:
>=20
> If the board is being powered by USB disabling the source and sink
> can remove power from the board. Allow the source and sink to be
> initallized based on devicetree values.
>=20
> Changed since V2:
>=20
> Change the devicetree documentation.
> Change the devicetree property names.
>=20
> Changed since V1:
>=20
> use devicetree values instead of hardcoded initialization.
>=20
> Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca>
> ---
> .../devicetree/bindings/usb/typec-tcpci.txt        |  6 ++++++
> drivers/usb/typec/tcpm.c                           | 14 +++++++++++---
> 2 files changed, 17 insertions(+), 3 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/usb/typec-tcpci.txt b/Docum=
entation/devicetree/bindings/usb/typec-tcpci.txt
> index 0dd1469e7318..b07418ae6482 100644
> --- a/Documentation/devicetree/bindings/usb/typec-tcpci.txt
> +++ b/Documentation/devicetree/bindings/usb/typec-tcpci.txt
> @@ -15,6 +15,12 @@ Required sub-node:
>   of connector node are specified in
>   Documentation/devicetree/bindings/connector/usb-connector.txt
>=20
> +Optional properties for usb-c-connector sub-node:
> +- init-vbus-source: set the initalization value for vbus-source to true.
> +  If this property is not present the initial value will be false.
> +- init-vbus-sink: set the initalization value for vbus-sink to true.
> +  If this property is not present the initial value will be false.
> +
> Example:
>=20
> ptn5110@50 {
> diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c
> index ca7bedb46f7f..10c14ece3858 100644
> --- a/drivers/usb/typec/tcpm.c
> +++ b/drivers/usb/typec/tcpm.c
> @@ -2462,9 +2462,7 @@ static int tcpm_init_vbus(struct tcpm_port *port)
> {
>    int ret;
>=20
> -    ret =3D port->tcpc->set_vbus(port->tcpc, false, false);
> -    port->vbus_source =3D false;
> -    port->vbus_charge =3D false;
> +    ret =3D port->tcpc->set_vbus(port->tcpc, port->vbus_source, port->vbu=
s_charge);
>    return ret;
> }
>=20
> @@ -4266,6 +4264,16 @@ static int tcpm_fw_get_caps(struct tcpm_port *port,=

>        return -EINVAL;
>    port->port_type =3D port->typec_caps.type;
>=20
> +    if (fwnode_property_present(fwnode, "init-vbus-source"))
> +        port->vbus_source =3D true;
> +    else
> +        port->vbus_source =3D false;
> +
> +    if (fwnode_property_present(fwnode, "init-vbus-sink"))
> +            port->vbus_charge =3D true;
> +    else
> +            port->vbus_charge =3D false;
> +
>    if (port->port_type =3D=3D TYPEC_PORT_SNK)
>        goto sink;
>=20
> --=20
> 2.17.1
>=20