Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp4227642imm; Tue, 11 Sep 2018 08:44:49 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYk5Mj7r+ssVA99YvhGJJEKSv/bXkGHEQZEaOG+t11R19yn97qvBHoAAhDsYm2RPHLw1n93 X-Received: by 2002:a63:790b:: with SMTP id u11-v6mr29292011pgc.111.1536680683750; Tue, 11 Sep 2018 08:44:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536680683; cv=none; d=google.com; s=arc-20160816; b=MrPffislmqMo/lC8f5NGmglbsA0JbNWZlwqqbGWxg5I2USoHf3HsufI+ootp7fpMuX k0B9zx+HradTRh4wT2knSJlNO0LVUKni57z06obNjA6XVxEgY6SfCaL2Ah2aadS1J1mN zyyKbeZlpHba7beVqDoC342pmDOolKtbXKTfuLZgnAXlwZY82dGeLx/pxltyX6cbAD44 bT9qXSWqM4/3V9pkvDBgEieqIlvY0Yr9MqWN0nAIGpPZCkzQSIe/BHOeUNKCe5nVixbe rtPrhDrLwbUE2AdXpg99UHXLN7MIeUbicFucr7HQ2eh6z9zjeWLKG1GfAqb0Ez3wCngi hhBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :reply-to:message-id:subject:cc:to:from:date; bh=lBiWFLhWBlUolB0f2uqnaTLXrN9cZDt/NuhqA/7FCos=; b=a/4T1ekZM/ahNIBhNsba9+g6/jSdsidl4W1OVnl2tuQbCzVlf/V4LehqseHHdVGyJJ t1l5S19hClN376WaxBBFgRG2kx+KR/DSWu8oiva8yLE0vggohe0BqdMZkqWcpqPIk6sh rcoHTrcx5SPCwBlqOMOEZCqoWmoLiqcZ17JRBC6Y+jX0UVMFl9f1b6uVAjUphbVsrTSh 4/zx/WuLiIIKSq/9kPQ7FCEQIrtXHLMRNPb8YwS1Q3G4xEUOzoEktWBJL2EQUfWZO6cD Bi2s6UGYOcb+TCrTJLsLCsZ9OJdNqGoExPnP11Z66hU2nKBh1GBLHU50Mh3HMQYfPomC /znA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s3-v6si21371706plb.270.2018.09.11.08.44.27; Tue, 11 Sep 2018 08:44:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727611AbeIKUn7 (ORCPT + 99 others); Tue, 11 Sep 2018 16:43:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:47720 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726670AbeIKUn7 (ORCPT ); Tue, 11 Sep 2018 16:43:59 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 7C74CAED3; Tue, 11 Sep 2018 15:44:05 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 04FFBDAD9B; Tue, 11 Sep 2018 17:44:04 +0200 (CEST) Date: Tue, 11 Sep 2018 17:44:04 +0200 From: David Sterba To: zhong jiang Cc: clm@fb.com, jbacik@fb.com, dsterba@suse.com, lufq.fnst@cn.fujitsu.com, suy.fnst@cn.fujitsu.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] btrfs/extent_map: Remove unneeded variable "ret" Message-ID: <20180911154404.GD2154@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, zhong jiang , clm@fb.com, jbacik@fb.com, dsterba@suse.com, lufq.fnst@cn.fujitsu.com, suy.fnst@cn.fujitsu.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org References: <1533474287-15049-1-git-send-email-zhongjiang@huawei.com> <5B7E9B1C.40404@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5B7E9B1C.40404@huawei.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 23, 2018 at 07:31:40PM +0800, zhong jiang wrote: > Hi, dsterba > > Can you pick up the patch? Thanks Please send one patch per changed function with relevant changelog that the return value is not used and that no callees could potentially return an error that would need to be passed.