Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp4246364imm; Tue, 11 Sep 2018 09:01:23 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZzybPNVAs7nq4xsCDiFEH9BEY1t/gH7wGfQz/irZDnK5joOnDmPxx7DR4nMrZAr44mUnSK X-Received: by 2002:a17:902:246a:: with SMTP id m39-v6mr27484362plg.57.1536681683207; Tue, 11 Sep 2018 09:01:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536681683; cv=none; d=google.com; s=arc-20160816; b=fgnpUKA3A0U2iVNBh6yPL0hUXWbp6KzUEVLqBLENgdgQAWSGO2/oB4zR3eXfjgGvbF sUhSC0KhSzAws8c2SD5GQbSxR0+BMffFixr5ZjGrcwEoPWHUsoMpowikX8ZOylD+Hoo0 jzPu8SbfXF+1FTCBO69yEkH37AlRISFPmMzvEx/6/ypkixVP3fnyNKOeZ+MdI1+fcKFG NaI9LQDgScv8pc09SHJrVTTeKHyg8MIjoVlvJRFpKKjvD+b5/fw+TU+gEgFHavNpyJFJ OISs1XzBBN+hP6sfiQ0uds3q40uWIf09Ap3YfnxABsJwmR1WNNaVCNDkfzo6CMOhuTzY bCPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=nKY9xqeZ3CG6AzivoiSKf7TCu1IWrMf9A7ethWJ6MhE=; b=lofroTW5NeQ5A524k9FDevyJLC77Trp7qim3n3TG5JW5fs4S43haa5DAl/8J6fTKvY b3Q5tFiT3HxTWmAk1eheGLWVORvvJc4rwrruHY6hiMluvXnJPKQbacxj9wrZG6lvAP0q Pr3A0CNK0AIGoVZFXb5Z6MiLzkwRLwyYgaP1X3pZH/AI6xuLYAp5VaucysvNcqDzEPnS LtDUdzAzpRAtTsqtlGyqTDYVgik7k1Ycs3Nmk5O9y0qcs7omEhAAaZWlWKRfPvoT3ssf Y8MUkUiE+b+SCvwbFD+w/Kg7BRouO/TcVxshtlpYXL3vwp3b6d1drXPleD5YnGmTALnp BRxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 34-v6si9856968plz.492.2018.09.11.09.01.05; Tue, 11 Sep 2018 09:01:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727007AbeIKVAx (ORCPT + 99 others); Tue, 11 Sep 2018 17:00:53 -0400 Received: from mleia.com ([178.79.152.223]:44880 "EHLO mail.mleia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726689AbeIKVAx (ORCPT ); Tue, 11 Sep 2018 17:00:53 -0400 Received: from mail.mleia.com (localhost [127.0.0.1]) by mail.mleia.com (Postfix) with ESMTP id 04FC24160E2; Tue, 11 Sep 2018 17:00:55 +0100 (BST) Subject: Re: [PATCH] mmc: mxcmmc: replace spin_lock_irqsave with spin_lock in ISR To: jun qian , Ulf Hansson , Kees Cook , Allen Cc: Randy Dunlap , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180911144701.53383-1-hangdianqj@163.com> From: Vladimir Zapolskiy Message-ID: <1c5cd9ec-3c33-0ad8-d1bf-a5d3883c9e5c@mleia.com> Date: Tue, 11 Sep 2018 19:00:53 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180911144701.53383-1-hangdianqj@163.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-49551924 X-CRM114-CacheID: sfid-20180911_170055_039862_A4ADCAEE X-CRM114-Status: UNSURE ( 5.03 ) X-CRM114-Notice: Please train this message. Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/11/2018 05:47 PM, jun qian wrote: > As you are already in ISR, it is unnecessary to call spin_lock_irqsave. > > Signed-off-by: jun qian Reviewed-by: Vladimir Zapolskiy --- Best wishes, Vladimir