Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp4267363imm; Tue, 11 Sep 2018 09:17:21 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaWneOKbe9pHe/6FWq4AIjjmsU8mIL9DrUOLRiGLdQByQBLIWryTzQ2GVB/CPwxKJ8Twopt X-Received: by 2002:a63:2043:: with SMTP id r3-v6mr29201241pgm.105.1536682641018; Tue, 11 Sep 2018 09:17:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536682640; cv=none; d=google.com; s=arc-20160816; b=Jni4fZC9HbFQbFVvBmg9tPhfouXZt8yE3wQYayOw/dFPcKc91sTPDh4O8GSZ9iqFIg jmKk4hat+M3LI8bjDLbhW10sgPaRxsXrpz+pOOipuXvb1CZfYkt9f5WfxWO5kHxQkhoN ZLVPaz0gMUlV913qjMHl4lxCh9gy0Bes0xbXgvTa6Ban6vpU3PS4fpYp8tf17YbdpprS q5nN+oNJZEIbtN0G/W/O1B5MquP9/W0iW8RLeGjZlUjXmhirKzMJPdikdeoxlW32j64n WA0PSXRN9YkSVI+Un5UI8fKFzYhSH8W35wnWmtIHnOWs+0skfauNIqspD7zRzXz0Y6Ip qE0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:subject:cc:to:from:message-id:date; bh=KSycDhPLokEI8AbcFrEforyPkwzXlGJYWT5Ch+h5qw4=; b=bAIKQrwpw0kSYvmq0zQHUD/5n+MSE6aboVm1jaEtOYiuq+cbRsqQ0esaFC+8e8zIUJ AqgY7B2B6lrrx/MKGCvDLlfezCQBU4QPlgLaxWG0byVUw4LOV0i6sNf5jhMzTS9xrY2m sCq432vf77QjtRoWl5CGx5Eb1Y++O9ZKBsrIDRpT/QcO4rPEikLyyTsGoM8vFVloQob4 ZuCVXldiAOhfxadKIinfkU1W74By2qv+PupNLkvmjsJG60KJmD+j0gCSe/tm1d5lH4EM pbFmFgtmtH0eePPAOhdiuZelt6qEwwTpe9V0Up8WLoEAuPaQMCrE+Emd7km7J8v+9jxe DpWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a186-v6si19943424pge.408.2018.09.11.09.16.58; Tue, 11 Sep 2018 09:17:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727384AbeIKVQk (ORCPT + 99 others); Tue, 11 Sep 2018 17:16:40 -0400 Received: from mx2.suse.de ([195.135.220.15]:54772 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726800AbeIKVQk (ORCPT ); Tue, 11 Sep 2018 17:16:40 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 2E885ACEA; Tue, 11 Sep 2018 16:16:38 +0000 (UTC) Date: Tue, 11 Sep 2018 18:16:38 +0200 Message-ID: From: Takashi Iwai To: Jens Axboe Cc: Paolo Valente , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [REGRESSION] bfq probe failed on 4.19-rc3 In-Reply-To: References: <8b5a7dc9-2dc1-16ee-4b05-a72eb6680c77@kernel.dk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Sep 2018 18:11:43 +0200, Takashi Iwai wrote: > > On Tue, 11 Sep 2018 18:09:44 +0200, > Jens Axboe wrote: > > > > On 9/11/18 10:03 AM, Takashi Iwai wrote: > > > Hi, > > > > > > I noticed that bfq doesn't appear in the I/O scheduler list on > > > 4.19-rc3. It seems that blkcg_policy_register() at the beginning of > > > bfq_init() returns -ENOSPC, hence the probe aborts silently. > > > > > > Is this already addressed? > > > > Haven't heard about this one before. What kernel did you last use that > > worked? > > IIRC, 4.18 worked fine. Let me see whether I have a backup... Confirmed that 4.18 worked. It's also with CONFIG_IOSCHED_BFQ=y and CONFIG_BFQ_GROUP_IOSCHED=y. And, 4.19-rc3 with CONFIG_BFQ_GROUP_IOSCHED=n seems working, too (as expected from the error above). (BTW I'll have to leave from this machine now. For any further inquiry, I'll check tomorrow, sorry.) Takashi