Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp4316728imm; Tue, 11 Sep 2018 10:01:54 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdb8d1HOXpOxcdAZ2dodL00et1DgJVfCMvI2/5wyMOAIOotg7Lnr6p6mAK+fkguzJPiNzRfy X-Received: by 2002:a63:7f06:: with SMTP id a6-v6mr29601996pgd.296.1536685314180; Tue, 11 Sep 2018 10:01:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536685314; cv=none; d=google.com; s=arc-20160816; b=UWSlVLdAGedtawkK8lfS8bxXxDPozVSUflf1PcqRpZtkmisEGcbMib0Ne2wwNgpt+c L8uJKn5jiA+HQmFMKqFGYczhwvpsX2Okfd7vPWH4DJNSkWsXpH1/EGGmWklwbwMcg4Fy Ts3zrEmbX5gMCpGa5f2Tx8K8FT8GVGBXSxz1UgLoUjOkqweVOHFSFIPO0wkjYTG9/wZ+ L9xIj5f/a5Bi00NJyxrM8Sg8WM1STL055dLQB5ykbJM6tXIn5VjwSxNY1aIy5Cg0WQlS NswdF3zZyJSKdQeCnO2DaCzv6zWXn16qabrPgrAVqlKmewwnCm66pm+NnCsXbeI7Nlk7 qMbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=zlpXk0pdaZQ6zi6anmgzU63WgKCRgO1Mv99iwvJLTng=; b=ne282lWKJ7ywACR/K4m/snohYCyTwPWYnI/hyu/z91Bd2dAve+XqBEI0kJ65naUgqY tqJoZgArvZ8MzSo28Xg3D4NavtbT+An7u78+9qGm5//LkfcgI84qa07fpqk3IbRI7KVz ko+sMxAIxTVGmZ3o0g+373iiPKpjHfXZ8uA2vjcmz+R5HbfewYz7H1GNHy7K8ccrJEDT /oqadXqZyivdnIJxuTPKYyZgW9APLnWDq4XlLPqXbFPWhCqHK5L2+NJ0nRPaTqoICrYK SR1eE437ybcRIZShEfvcYeo1w8xPsiVanHxKxTbQILAkTaYzp3gxv5dmrYn8P2CWLz+C qgxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=gdcIdHQH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b2-v6si22849002plm.202.2018.09.11.10.01.35; Tue, 11 Sep 2018 10:01:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=gdcIdHQH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727996AbeIKV7z (ORCPT + 99 others); Tue, 11 Sep 2018 17:59:55 -0400 Received: from mail-it0-f53.google.com ([209.85.214.53]:51559 "EHLO mail-it0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727754AbeIKV7y (ORCPT ); Tue, 11 Sep 2018 17:59:54 -0400 Received: by mail-it0-f53.google.com with SMTP id e14-v6so2484480itf.1 for ; Tue, 11 Sep 2018 09:59:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zlpXk0pdaZQ6zi6anmgzU63WgKCRgO1Mv99iwvJLTng=; b=gdcIdHQHQEIESWZA7ePjOgNZLmecI7zKeM2YIYRiZvR/ijtRKUQUT0G6ekGhWCGOw1 yBvnDlIu6ELAt5A8dcjevaFq27MQSRGm5KaYc+FIlZc4udwefBxUJt+heRVT+l4N36ZI TqxNU09OEQ8K/2f4AflAgjHVxDUqvVl4H9l7AAd0WQfE38BHnBmnsxb7NgQDJ35ZhEtD GVnP2UM7F7uEZXwoyIOVsgTS9rDUecNAr3J52QVzrP/60ucElHy129AzQXTvVqWH15M1 d9/NjZSwgMYP7VM51EL+mektS2MaDb1SRyLNW7TojR4X6cyXpvhv9YKXwqataG5SnNHm StgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zlpXk0pdaZQ6zi6anmgzU63WgKCRgO1Mv99iwvJLTng=; b=fC5jVxuzWWJaU43q/e7O01CnL38sGO9u5dolfB9/7NCCAoZA3r2PJtdsk9jPz4WYtY opu2AqeWj5T7bmE4nKIzt5VZkG/OOzV0yBe1ahScZww1dHuEOmsPYT+fGGJOUb79CkQI yjbBGt7+H/Mh4G7scRcBKJah/dd5q/fwRQnF2oopqvb9QKJIkDOIUSznpc7zRMDAUCG+ CYWUdS3soQqwgFOP22yT9NZa8jsUvzMnzMAKvn8XTOPWcVBRPDR6aZKwkoq00TSzIDNA MyvEq5zor5LU4XIzIf2n4fVecacibpUiwxkvcNJw1+cfALlCyc59dcvWqMOhmDs36Gom l0Jw== X-Gm-Message-State: APzg51BRU+3kBusgne1hZQcEM/uQc9sLbsOfuXy2x2Od3h30WEPuJJyh DIUSnYrP6pAOdAkv83KTaXiGK4l37w0= X-Received: by 2002:a02:4add:: with SMTP id s90-v6mr23894698jad.21.1536685182116; Tue, 11 Sep 2018 09:59:42 -0700 (PDT) Received: from [192.168.1.212] (107.191.0.22.static.utbb.net. [107.191.0.22]) by smtp.gmail.com with ESMTPSA id t4-v6sm7813889iof.55.2018.09.11.09.59.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Sep 2018 09:59:40 -0700 (PDT) Subject: Re: [REGRESSION] bfq probe failed on 4.19-rc3 To: Jeff Moyer Cc: Takashi Iwai , Paolo Valente , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <8b5a7dc9-2dc1-16ee-4b05-a72eb6680c77@kernel.dk> <8d5f3ab2-50e8-226c-8ccb-c722872910db@kernel.dk> From: Jens Axboe Message-ID: <046d0a8c-fe66-f933-fc27-f6d9f075884c@kernel.dk> Date: Tue, 11 Sep 2018 10:59:39 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/11/18 10:57 AM, Jeff Moyer wrote: > Jens Axboe writes: > >>> And then there were 4... >> >> Exactly. I'd bump it to 5 to leave room for one more, if we have to grow it >> again, probably worth it to make it dynamic. So for, not really needed. Takashi, >> can verify that the below fixes it up for you? >> > > You can slap a > > Reviewed-by: Jeff Moyer > > on that when you commit it. Thanks, I'll do so when Takashi has given it a test spin. But seems like a no-brainer. -- Jens Axboe