Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1536689787.3024.130.camel@codethink.co.uk>
Subject: Re: [PATCH 4.4 105/124] xen-netfront: wait xenbus state change when
 load module manually
From:   Ben Hutchings <ben.hutchings@codethink.co.uk>
To:     Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Xiao Liang <xiliang@redhat.com>
Cc:     stable@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Juergen Gross <jgross@suse.com>
Date:   Tue, 11 Sep 2018 19:16:27 +0100
In-Reply-To: <b783c784-1bb0-32ad-07ad-a05b06a928d9@oracle.com>
References: <20180804082702.434482435@linuxfoundation.org>
         <20180804082706.393252081@linuxfoundation.org>
         <1536279682.3024.95.camel@codethink.co.uk>
         <b783c784-1bb0-32ad-07ad-a05b06a928d9@oracle.com>
Organization: Codethink Ltd.
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 2018-09-07 at 13:27 -0400, Boris Ostrovsky wrote:
> On 09/06/2018 08:21 PM, Ben Hutchings wrote:
> > On Sat, 2018-08-04 at 11:01 +0200, Greg Kroah-Hartman wrote:
> > > 4.4-stable review patch.  If anyone has any objections, please let me know.
> > > 
> > > ------------------
> > > 
> > > From: Xiao Liang <xiliang@redhat.com>
> > > 
> > > [ Upstream commit 822fb18a82abaf4ee7058793d95d340f5dab7bfc ]
> > > 
> > > When loading module manually, after call xenbus_switch_state to initializes
> > > the state of the netfront device, the driver state did not change so fast
> > > that may lead no dev created in latest kernel. This patch adds wait to make
> > > sure xenbus knows the driver is not in closed/unknown state.
> > 
> > [...]
> > > --- a/drivers/net/xen-netfront.c
> > > +++ b/drivers/net/xen-netfront.c
> > > @@ -86,6 +86,7 @@ struct netfront_cb {
> > >  /* IRQ name is queue name with "-tx" or "-rx" appended */
> > >  #define IRQ_NAME_SIZE (QUEUE_NAME_SIZE + 3)
> > >  
> > > +static DECLARE_WAIT_QUEUE_HEAD(module_load_q);
> > >  static DECLARE_WAIT_QUEUE_HEAD(module_unload_q);
> > >  
> > >  struct netfront_stats {
> > > @@ -1335,6 +1336,11 @@ static struct net_device *xennet_create_
> > >  	netif_carrier_off(netdev);
> > >  
> > >  	xenbus_switch_state(dev, XenbusStateInitialising);
> > > +	wait_event(module_load_q,
> > > +			   xenbus_read_driver_state(dev->otherend) !=
> > > +			   XenbusStateClosed &&
> > > +			   xenbus_read_driver_state(dev->otherend) !=
> > > +			   XenbusStateUnknown);
> > >  	return netdev;
> > >  
> > >   exit:
> > 
> > This won't work; it will hang.  Something (maybe netback_changed()?)
> > needs to wake up tasks on the module_load_q.
> 
> 
> https://lkml.org/lkml/2018/9/7/691

Thanks.

Ben.

-- 
Ben Hutchings, Software Developer                         Codethink Ltd
https://www.codethink.co.uk/                 Dale House, 35 Dale Street
                                     Manchester, M1 2HF, United Kingdom