Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp4528974imm; Tue, 11 Sep 2018 13:22:18 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYyXmw1nLJZSr2H5UDZmqf8DftNGrC2H8LNSa3ym2UyHwZ2NoL1ti65UNSp6FizxMPSaqHQ X-Received: by 2002:a63:d74f:: with SMTP id w15-v6mr30168185pgi.306.1536697338780; Tue, 11 Sep 2018 13:22:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536697338; cv=none; d=google.com; s=arc-20160816; b=ruNkEZJ2QqRpm3YT9QEimtDBzWZ66GQ/MwWQIT2x3DPkqV8SWhhdj79doSdgfJbOTY zZQk7uMdPL095aR0zXXC3CiGx86VxVjhb+XYZdM5VkMgEVOgaJ1z7EEOH1CXMzkbqRcy abowyasdwVlfEVAJhK+rHePNHEF6OUwpDvzYzU4xI8oKTckSbDpPyFXgFUjzO3igeT/8 ompggwPLoGsnV1/J9sYQUdWh0Vn0tpQ4NI3luKZ1ZY1Y8P8DHKO4fuQ8gsmlW7aKK4Oy ZwNONSmXBrIJ51xKHRFU/wjT19hzJLqK6obUlLTBqdAOPQVDt7fjEjeA53eAt8xYmQuV eZdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=Z28ykTVRmJmQc3VrFjO9GhSc8EGFT5V3NJCgE1bz0S0=; b=mLzPLdWrPii8C076hqV+RBAgGfKrJ9pVWFmh6t2RCh38Pr0ghdDA43u6WXO1RDwWkY 5jTNExzDo7kWZF38SzTbxSPfUrKfC9TkYm9VUD9GLRkwEviEz4tx7kehaBb4UlBk7Kpy L8MlxSf6gl2BT2Fj5a6tVATTHxJMDqXB/sW4Axgz4HwCcCx+x9MAI0nAGMzYNz3Ryw/8 idio+jmvMzSB9j2L7ovFpHUAbHnzsUR9QF7kTpAInDPSfZQL0rPhiGfsNc6dRa097Jdh xWkyRONVe8l0GVxFMHZxJ+iBZy65WpEdYaxUoZgO8u/sOoJ1rxRDCI/Mw3/4YyapNac3 o8Ww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o4-v6si21240475pfh.168.2018.09.11.13.22.03; Tue, 11 Sep 2018 13:22:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727277AbeILBVU (ORCPT + 99 others); Tue, 11 Sep 2018 21:21:20 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:42313 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726720AbeILBVU (ORCPT ); Tue, 11 Sep 2018 21:21:20 -0400 Received: from p4fea45ac.dip0.t-ipconnect.de ([79.234.69.172] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1fzp8r-00058s-SF; Tue, 11 Sep 2018 22:20:10 +0200 Date: Tue, 11 Sep 2018 22:20:09 +0200 (CEST) From: Thomas Gleixner To: Boris Ostrovsky cc: mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, jgross@suse.com, andy@strugglers.net Subject: Re: [PATCH] x86/EISA: Don't probe EISA bus for Xen PV guests In-Reply-To: <20180911195538.23289-1-boris.ostrovsky@oracle.com> Message-ID: References: <20180911195538.23289-1-boris.ostrovsky@oracle.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Sep 2018, Boris Ostrovsky wrote: > For unprivileged Xen PV guests this is normal memory and ioremap will > not be able to properly map it. > > While at it, since ioremap may return NULL, add a test for pointer's > validity. I assume this goes back to very dead kernels, so that should go with a Cc stable, right? Thanks, tglx