Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp4572965imm; Tue, 11 Sep 2018 14:12:01 -0700 (PDT) X-Google-Smtp-Source: ANB0VdacHWgrGD3A0b6cvm30hVWZjgF1Ilk/Ua/9l98+qRlbmujLeeJv8qf0ODpVV8DE7AmEMTtX X-Received: by 2002:a17:902:8a90:: with SMTP id p16-v6mr29434219plo.106.1536700321782; Tue, 11 Sep 2018 14:12:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536700321; cv=none; d=google.com; s=arc-20160816; b=ZVfwoRrz2qukQwG89yd9tbsaMRwbJuNH36uYrEPnAOXZPZFelIqzW413c2fQSTZsae d7HBtkk4OfHAwivy+ci3KPkNEUKTa9zV/N0g3oOx6PTCy4P8Ra5GwHl5SjIZ/1xB65tj 9dzz2UF/w+GOe55b30i4/7bCVik3186jtoDtXBLAScrJmepiKor5gqwk+dl7eHQTyp2k N/GrVbEGA6jYPqVZpNJtzDKxsLcrp9Glfywa8fmdGxLqCZs9wwbwt5XyuB19SBgj3+as zdOoSWO8QQVyoMa88iswX4nLYIvZyC54eXhpCJh7erFS8GzOSVKZXENvbUjtCwVpU6mK wqZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=ZSfVtm0rkW69j5fwP0M6Ab4Krs645uZH/1TcfHFsqZE=; b=SaLvmfV8QOTYQ5sIl8syZjiN2VhFuSvXGxGABzdp3M/DDdZjGKoc18axwnYK6T80QE 4nVWWOToW7lm1TcMgg3A/o+lPtlM/fYKN4EmDg9cToa26wnIhOs7ltYf+gOoQN0J2e57 mDasE2bcGiHI/PL1d4/d8JqYNxx5fvh/Ww6T7VNqFfmTvVEUciINybD4zaPiptpzqTzH Mxq1xkfST7IySbIHmF4f5ZBmUH8zbWfvr/Hywl+yPe9nwDB6ZtzMuyWwIdKGJWchF4UA oKHe6cKAjSIMA1SHn18+cFQT1eTEDVaKTYN1vgQF/szTn2aVb75l9RPI1w5N9ls8I85X k8Eg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=mail header.b=utaAIAB1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d2-v6si20196933pla.307.2018.09.11.14.11.45; Tue, 11 Sep 2018 14:12:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=mail header.b=utaAIAB1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728090AbeILCMp (ORCPT + 99 others); Tue, 11 Sep 2018 22:12:45 -0400 Received: from frisell.zx2c4.com ([192.95.5.64]:59133 "EHLO frisell.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726870AbeILCMo (ORCPT ); Tue, 11 Sep 2018 22:12:44 -0400 Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 0d9cd3f5; Tue, 11 Sep 2018 20:54:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=mime-version :references:in-reply-to:from:date:message-id:subject:to:cc :content-type; s=mail; bh=7d2/Vp3t6DO4Yv49mC5jGFj7vTI=; b=utaAIA B1IA47JIb4BLGNwcif6N1BeNWgI6j/pdjcu+3eUh/W5F72GVOUNugWuwwV3RzufR aky9nv+h4aqQofSrqQ/VHs1KDFQfFOWMECBR+waIs2wvIRcVrw/2714bsi2n16vm nuZySBOl14fO16IeffmTj4zS6ZLXIwPKF/diEfie0dn/JGWVpZLTcSkit8DChBuk KbfIfdNoRQzabDqwT89jpIWu0Blaiie252/VbKYIs3pPOpCKJLFeQ3foxpyxJgCL 8ae1Bylp+Dhq1txcSYQ6+uhZB+/clkQFy7seEbINGdahaMWIy4Q7HhAmhzwAzAdb NGuz3Exg3Ch0zyMg== Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id d80d2deb (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO); Tue, 11 Sep 2018 20:54:48 +0000 (UTC) Received: by mail-oi0-f44.google.com with SMTP id t68-v6so50008085oie.12; Tue, 11 Sep 2018 14:11:30 -0700 (PDT) X-Gm-Message-State: APzg51BSL5UgKveo7SsFJ/NhxdzUKb4QQ8QlZgARIVXX+90m2MGIbO6i MPdENWX+fdo8hPhlOIWe3ucNGv2yN9xm/l7b3IE= X-Received: by 2002:aca:2e86:: with SMTP id u128-v6mr27179157oiu.132.1536700290059; Tue, 11 Sep 2018 14:11:30 -0700 (PDT) MIME-Version: 1.0 References: <20180911010838.8818-1-Jason@zx2c4.com> <20180911010838.8818-19-Jason@zx2c4.com> <20180911133017.GJ30395@lunn.ch> In-Reply-To: <20180911133017.GJ30395@lunn.ch> From: "Jason A. Donenfeld" Date: Tue, 11 Sep 2018 15:08:07 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH net-next v3 17/17] net: WireGuard secure network tunnel To: Andrew Lunn Cc: LKML , Netdev , David Miller , Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Andrew, On Tue, Sep 11, 2018 at 7:30 AM Andrew Lunn wrote: > I don't know if any of the crypto people are reviewing the networking > code, but i don't think there are many networking people reviewing the > crypto code. > > So please can you put the change log between versions for the > networking code here, where we can easily see it. All submissions >v1 have had a changelog in the 00/17 commit. > I see you have yet again completely ignored my request to either > 1) Remove the inline > 2) Argue why it should be kept. Most uses of inline are this way after checking the compiler output on several platforms. (Generally my build-run-test cycle is actually build-IDAPro-run-test.) If you feel that's been done too liberally, I'm happy to spend time rechecking each use case.