Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To:     zhong jiang <zhongjiang@huawei.com>
Cc:     airlied@linux.ie, tomi.valkeinen@ti.com, sre@kernel.org,
        afd@ti.com, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/omap: Use ERR_CAST directly instead of RR_PTR(PTR_ERR())
Date:   Wed, 12 Sep 2018 00:19:58 +0300
Message-ID: <2081575.ibfeOaj4ye@avalon>
Organization: Ideas on Board Oy
In-Reply-To: <1536666875-11252-1-git-send-email-zhongjiang@huawei.com>
References: <1536666875-11252-1-git-send-email-zhongjiang@huawei.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Zhong Jiang,

Thank you for the patch.

On Tuesday, 11 September 2018 14:54:35 EEST zhong jiang wrote:
> We prefer to use ERR_CAST to do so.
> The issue is detected with the help of Coccinelle.
> 
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

I expect Tomi to take this patch in his tree, but I also applied it to mine to 
make sure it won't be forgotten.

> ---
>  drivers/gpu/drm/omapdrm/dss/dss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c
> b/drivers/gpu/drm/omapdrm/dss/dss.c index cb80dda..1fc46b2 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dss.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dss.c
> @@ -956,7 +956,7 @@ struct dss_debugfs_entry *
>  				&dss_debug_fops);
>  	if (IS_ERR(d)) {
>  		kfree(entry);
> -		return ERR_PTR(PTR_ERR(d));
> +		return ERR_CAST(d);
>  	}
> 
>  	entry->dentry = d;


-- 
Regards,

Laurent Pinchart