Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp4611569imm; Tue, 11 Sep 2018 14:56:24 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZ81/pi5nDkD2xuPqVzSSsddZTgHkPnvQYGsY3QsUIrcpmlhwbRyo4X9BRVakjbpcNuaZ4O X-Received: by 2002:a17:902:29e3:: with SMTP id h90-v6mr29280642plb.215.1536702984818; Tue, 11 Sep 2018 14:56:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536702984; cv=none; d=google.com; s=arc-20160816; b=nLIlZ8tISaP32RzYCEFwdVeNT7iw6QlCYFtjgSakilGL080J03yYxVelrpEWxLCRdR YKXUkSm2g1w5GrZxeV4/TVWWEyJf4Be9mDus6+tpJxKuK3HTiL0jiRB0NHSxzW5ECwYL HSUu0tnHvpaHYDIjdRjQEpaFoKOdQEaBfJ2NkuBSsYMsv/SVQEdhaFkcbsCn6tgf1VC2 KXKFBSju3POGoH0qkm/CH8TEZuBAJk/mamcgfjnFyO0UkOwFiWgt25WScwIRrXgOTVtb MyS/IoZrLOUmeIbflvc3ncoCBz6mggwJ7BjZ4ghpuV8p5q9+uZiXWi0sziKhTbGs1bCF Fl/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=B6YeQnveHNafZdHz6a8g6lcpiJENPNVZGCmMjS8k27M=; b=B6KCNrYGhzTtKXWlHbZDCC9kmwRdUToh88i3BfgoMipINLWYvyaRL1zVcPqe8ekwUg l1OjqRFSVPK1KByarwJrn09M7wZKGb16Wv69Gu6rLTcrnRSpnMic0odhwg9Xv4VC0iDr 4jgez1CZegCwHUpFruM5vNv5IpypWn0jkWmf9Jab02sWOufkJy5pash0kWK+HTERtdH/ KH10pxz1/OWHxCl7QErgTjjOzEzA0sdlMmO/oR5EiPdh+7DeRgUo8zKeLbl10A0PhZ7a zdStNzT1caTWtpHcB6n61zdzTbL8e2/aZZpSWo787URbxi9m+ajiFdOCl1TMuLfXphCa /USg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=5kNSoFfC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f2-v6si21504636pgh.661.2018.09.11.14.56.09; Tue, 11 Sep 2018 14:56:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=5kNSoFfC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728170AbeILC5B (ORCPT + 99 others); Tue, 11 Sep 2018 22:57:01 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:59473 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727775AbeILC5B (ORCPT ); Tue, 11 Sep 2018 22:57:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=B6YeQnveHNafZdHz6a8g6lcpiJENPNVZGCmMjS8k27M=; b=5kNSoFfC4A3n5Q+7A7lrbXLUKkNwhRA0kccFy981o3dBPTnIxjPdB/vIcDG1C8HJEy0WZwbJsG87ubTZHeRNj8SJwPTi02BIrqOueoKU2usGbzP2oVaeO4QQ8j7uepHGorYiJITt7Ii5jRY1vt76HIye18xKCMbalJmlOUE6Gdk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.84_2) (envelope-from ) id 1fzqdI-0002bD-1Y; Tue, 11 Sep 2018 23:55:40 +0200 Date: Tue, 11 Sep 2018 23:55:40 +0200 From: Andrew Lunn To: "Jason A. Donenfeld" Cc: LKML , Netdev , David Miller , Greg Kroah-Hartman Subject: Re: [PATCH net-next v3 17/17] net: WireGuard secure network tunnel Message-ID: <20180911215540.GC32007@lunn.ch> References: <20180911010838.8818-1-Jason@zx2c4.com> <20180911010838.8818-19-Jason@zx2c4.com> <20180911133017.GJ30395@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Most uses of inline are this way after checking the compiler output on > several platforms. (Generally my build-run-test cycle is actually > build-IDAPro-run-test.) If you feel that's been done too liberally, > I'm happy to spend time rechecking each use case. Hi Jason I really expect DaveM is going to come along and tell you to remove them all. You need a strong argument that they are needed, since this goes against the general consensus in the kernel, that the compiler is better at this than humans. Andrew