Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp4761639imm; Tue, 11 Sep 2018 17:47:40 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbUf8ajW9c7akWDUKo1HMygGaiG2lY25W6w+ur21wolXjoQ+ZU+hDKWWnS/xel9+ghpkyr1 X-Received: by 2002:a63:bd41:: with SMTP id d1-v6mr31117138pgp.309.1536713260207; Tue, 11 Sep 2018 17:47:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536713260; cv=none; d=google.com; s=arc-20160816; b=VZOBMlqQPEitLLJgGK526CSkquk4ZHSBAPvn2b9AxPJiWdLVATZ0/LxftcmdYe3s7n Ri5PmjR4g9/pp5DavjNjYCEVTDzgRIhXh92crxMi4VUDbES7JNDwJ/KtHFpDkyB07TfX n2DvoeksFErI0A1Rradr5DcfNY6kFNnGVORaNFn/3k/AEicq2Gj3LFJHrjctgzriMzsu C6eK3xkh7y+QfBLwUQ1Qm5K8Za7xpIrq793PMhjaTnCkgAz20wP3CVDP9ZXMmXBkzZBB ZwrF0v7cBThiWG5T1X8btnRCB4us55zFkJaVYx2Y71z5lr+lTtC84BEN7mhCp7b+Pxfq R0Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=cgMdj1GL9H89WSuRK5TA4RCmtpIB8WHECHAF7lDcS4s=; b=KnRT12wnyJJSZlKN7M8nnY8hnihcAQo6H2kh4I6Drhn+VL9Fh+ZxysWsErUOfO+d/k kOX6c3FDhF4bSJ3sSJUTGE3GDKtWNzDZDsCqbS9GUiolrHkTKOcF3M6Fv0TE4oDccyjo 1VlGYhKkF+BNo1SzH7dw3iwUzSsJHULV3vITlSZRIfqfBmA56zBcvTIC7gJ3l7ChsaiT c8TfDC1cxtBznkcTY4TK/+JbpVRk3GjmUP/WQStBtLNrf3IqemezzgCyAtUhptIyUmcb Kmi5MZMAT81GPkOaVC+rbL42w/SG4jz8+DMJiaXHVIbiT7a8vCvFZbXv5m9Fanovb4eg x5lA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=cnDOAdn0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c3-v6si21806606pfg.181.2018.09.11.17.47.25; Tue, 11 Sep 2018 17:47:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=cnDOAdn0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728119AbeILFsh (ORCPT + 99 others); Wed, 12 Sep 2018 01:48:37 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:34858 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727942AbeILFsh (ORCPT ); Wed, 12 Sep 2018 01:48:37 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w8C0hbLS029359; Wed, 12 Sep 2018 00:46:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=cgMdj1GL9H89WSuRK5TA4RCmtpIB8WHECHAF7lDcS4s=; b=cnDOAdn07456l1YUhBdTbDfa9sOToDVVps1sQlpPnRtzfsJBdWiJktaH5HKDA1Xkjyz+ MkWPKm1/rC6CV/dsQYhczIxW9JACm2Y0fmzD6Rd2sgNEJj3B5gzIKFa/bXJVQlz+TBxW zC8mUZH39/d1/BQ3GMT6Q7U0oc/8KNjBnHRZtpdW3ldWsr76hKjne4Ifdz9CHjp3jrQG nPT8AtjWcPqJLukHVHVK6Fx7yydLRuTEeOUNpMpJ7ISqByjN58khByh5nDv3v80EwwMf HGAraeU9KoUFuqYvnxk0L0fEfoBdnuJmVKSoeow6JdrmzQOnqug8/a8Yeggrv7p3a7ri wg== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2mc72qq799-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 Sep 2018 00:46:38 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w8C0kbnp019987 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 Sep 2018 00:46:37 GMT Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w8C0kaf0019234; Wed, 12 Sep 2018 00:46:36 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 11 Sep 2018 17:46:36 -0700 To: Laura Abbott Cc: "Nicholas A. Bellinger" , Bart Van Assche , Hannes Reinecke , Mike Christie , Maurizio Lombardi , target-devel@vger.kernel.org, linux-kernel@vger.kernel.org, Kees Cook , "Martin K . Petersen" Subject: Re: [PATCHv3] iscsi-target: Don't use stack buffer for scatterlist From: "Martin K. Petersen" Organization: Oracle Corporation References: <20180904184740.11102-1-labbott@redhat.com> Date: Tue, 11 Sep 2018 20:46:33 -0400 In-Reply-To: <20180904184740.11102-1-labbott@redhat.com> (Laura Abbott's message of "Tue, 4 Sep 2018 11:47:40 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9013 signatures=668708 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=485 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809120007 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Laura, > There are two cases that trigger this bug. Switch to using a > dynamically allocated buffer for one case and do not assign > a NULL buffer in another case. Applied to 4.20/scsi-queue, thank you! -- Martin K. Petersen Oracle Linux Engineering