Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp5263570imm; Wed, 12 Sep 2018 03:36:52 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbvvvLPMabhUTJeGI3tstNS0EZriIVmBZH+b0MKbeGzf6E5KNvXCiTSrLGk4zRkvOJSrx+B X-Received: by 2002:a63:931b:: with SMTP id b27-v6mr1464234pge.143.1536748612267; Wed, 12 Sep 2018 03:36:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536748612; cv=none; d=google.com; s=arc-20160816; b=ZGGpcPkHBW2gEFbXFnhbvQiu0GLHLHoybPiL+lReheX+Y3PwBZfQbA1wNrPNnIVwCK XpPghJIvguq2TBkORJbZ6/6Egv5iXUvpONZN2pLbHOXkafP0aAqSIHUZxC1rrHDlUrq0 oJzsEQlD8Fu0WwR073ldi9Sr8ULDc9TMNgaePOi3fsOqZCOHDx2/2qzN1ayDUbfa5xQm RBlvQNVM+hsBv4Mz1iGbAUuxCcrzW68crEKnyoarPN94Ql+GlMchTjmdPvdL8xQGzA3Y cyevR9/xcXpakEnL7+81MbmZEtp1kyoeZTQDzeLL90mkUR+tnt9CnEfDBosbFLTH3xgF GHbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from; bh=n3a5lEKI1q6GiefcohzU+p4lIe27ngAdDRzYMS3bZTM=; b=oc+ufkRDNF134KVZXte7k3yui9Qo/2lYhGmn2j8JtrJUxlW5rJ3XFQKsm4qcC7qVCL NLKIw1OPQUXQub+Q+G5DMLBdW5oA3VEkNBrjsVv4RZQ/suOg0C6+fk37IU167mj7qlf4 DbVjR27rtz2Qo/4bnXP5YEJxwEex+8706f354HDaSIwEkty9kspNbRJm7jWnkQ5XLoW9 tMuZIqQyOE5p9fS9em55D+K1t4uRYJoPYkC7P53JFOsrThWkK0v9SZZ2eklZSG0H7eR9 bt3Pl5MbMA2J5CKhAKNsJbweQkunfp1hUbQ1AgagvO3lYBsoO4BrpiiYzsYOaevJUiss SPwQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1-v6si608857ply.483.2018.09.12.03.36.36; Wed, 12 Sep 2018 03:36:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727697AbeILPkO (ORCPT + 99 others); Wed, 12 Sep 2018 11:40:14 -0400 Received: from mail.parknet.co.jp ([210.171.160.6]:57162 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726855AbeILPkO (ORCPT ); Wed, 12 Sep 2018 11:40:14 -0400 Received: from ibmpc.myhome.or.jp (server.parknet.ne.jp [210.171.168.39]) by mail.parknet.co.jp (Postfix) with ESMTPSA id 3548A15AF4A; Wed, 12 Sep 2018 19:36:17 +0900 (JST) Received: from devron.myhome.or.jp (foobar@devron.myhome.or.jp [192.168.0.3]) by ibmpc.myhome.or.jp (8.15.2/8.15.2/Debian-11) with ESMTPS id w8CAaFMI030465 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Sep 2018 19:36:16 +0900 Received: from devron.myhome.or.jp (foobar@localhost [127.0.0.1]) by devron.myhome.or.jp (8.15.2/8.15.2/Debian-11) with ESMTPS id w8CAaFQE010409 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Sep 2018 19:36:15 +0900 Received: (from hirofumi@localhost) by devron.myhome.or.jp (8.15.2/8.15.2/Submit) id w8CAaFkg010408; Wed, 12 Sep 2018 19:36:15 +0900 From: OGAWA Hirofumi To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] fat: Relax checks for sector size and media type References: <20180902131932.11558-1-pali.rohar@gmail.com> <87bm9ft5h5.fsf@mail.parknet.co.jp> <20180903074005.7e3guj24ksq2l44c@pali> <874lf7t3gg.fsf@mail.parknet.co.jp> <20180903080422.ta3clnhr5bobv6il@pali> <87zhwzro1o.fsf@mail.parknet.co.jp> <20180912101750.6slpi3puoww72xsj@pali> Date: Wed, 12 Sep 2018 19:36:15 +0900 In-Reply-To: <20180912101750.6slpi3puoww72xsj@pali> ("Pali =?iso-8859-1?Q?Roh=E1r=22's?= message of "Wed, 12 Sep 2018 12:17:50 +0200") Message-ID: <878t47roio.fsf@mail.parknet.co.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pali Roh?r writes: >> If there is real user to use that, I'm ok though (of course, need >> serious tests). However, FAT would be for exchange data with other >> devices, and there is "cluster per sector", and spec recommends sector >> size == device sector size. So I suspect this format is not useful. > > I looked into OpenBSD, FreeBSD and NetBSD source code and there is no > explicit upper limit for sector size. Just that sector size must be > power of two. > > I have not did tests yet, but you are right that some testing should be > done. > > As FAT operates with clusters and cluster size is defined by sector > size, then sectors per cluster and sector size defines cluster size. And > cluster size itself implies maximal size of FAT filesystem. > > So increasing sector size could be useful to create larger FAT32 > filesystems as current limit hit by sector size = 512 bytes. > > What do you think, which operating systems should be tested? Again, I suspect those custom extension (can't read by some uefi or windows) is not useful though. Testing on kernel that has PAGE_SIZE >= 8192, and setting FAT sector_size >= 8192. After that, it would be safe to remove 4096 limitation. Thanks. -- OGAWA Hirofumi