Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp5381337imm; Wed, 12 Sep 2018 05:22:05 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYz+0Ikl+pc8eaAinZdyVJZyCNRwyKbYanvTmt7kPYqBfDmUhv07Fc0E9iaBOin6sShmes5 X-Received: by 2002:a17:902:4d45:: with SMTP id o5-v6mr1986616plh.78.1536754925377; Wed, 12 Sep 2018 05:22:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536754925; cv=none; d=google.com; s=arc-20160816; b=DAnhiVDS8ZLVgkSnkOZWC/JBPTLmzkmMzqbB9OJ3whyQC8ykz5I+kTczBu1Joquvv7 RHPTJHo3wHK1cU39ULdBqKB+nQQUlvC7Wn1p1MMxBsivaIHCmqoriwu00mRHgJSey3l7 p9S7p/3xwXxC1C3pRjpNCcEPFLel3MFGtfrXkh5OTpHE3Ka/qG+rJ8H/MW4EIeISW1sE KHCvAymgwnW2taVTlfhIgIADbS2VEHQAD7owcrkrJDybp2AUiakQxoKrxQtlqyktOnvm q/NJ+OBD+6SIKN9T7lqk4xNlfrztdEVW6tVs1x1uq9KnvVclzDMVBTQBz1JU3PvWDa4R MuhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=r6cxYnsx+HPQY4xwXl6Q4aCYxDslckcDoymzSRJHTOQ=; b=k1KRSTP27KoGaLXX/Y8OmMxfNJs+cgRh5kSRGwBX/WjEglgkQq5wNWStCKMlIA9spC WSvqeS/AcjqiLDxreAnzGvJXUmJVs+uCgAhLTwFMWEI09FiNdsqRJynf0MT9yj3Yhghj iWv240uz8G5vlXMDdHqxCn5c3Qvz1nIGUH4CDkNWKvzmoIklGlHzT+tdPlBvGlB4+SG9 6bqnz1SIBXgYbFQGI1j/FT7KUe1NCmL26XWhXNPDzGZJHdi+qm7+Y5p6jxk7pM2cv716 BuPHqoTJxn/etbSYyQv8YOTVR6bry1WhizxPYfVTFwD2C/i66Bh/BYT14QIgzeNceyDI PLow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o18-v6si977140pgh.91.2018.09.12.05.21.50; Wed, 12 Sep 2018 05:22:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727673AbeILRZv (ORCPT + 99 others); Wed, 12 Sep 2018 13:25:51 -0400 Received: from mx2.suse.de ([195.135.220.15]:49466 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726491AbeILRZu (ORCPT ); Wed, 12 Sep 2018 13:25:50 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id DECBCAD53; Wed, 12 Sep 2018 12:21:32 +0000 (UTC) Date: Wed, 12 Sep 2018 14:21:32 +0200 From: Michal Hocko To: Zaslonko Mikhail Cc: Mikhail Zaslonko , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Pavel.Tatashin@microsoft.com, osalvador@suse.de, gerald.schaefer@de.ibm.com Subject: Re: [PATCH] memory_hotplug: fix the panic when memory end is not on the section boundary Message-ID: <20180912122132.GF10951@dhcp22.suse.cz> References: <20180910123527.71209-1-zaslonko@linux.ibm.com> <20180910131754.GG10951@dhcp22.suse.cz> <04b427ad-df4e-67bd-2942-2a7a2cccf1aa@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <04b427ad-df4e-67bd-2942-2a7a2cccf1aa@linux.vnet.ibm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 11-09-18 16:06:23, Zaslonko Mikhail wrote: [...] > > Well, I am afraid this is not the proper solution. We are relying on the > > full pageblock worth of initialized struct pages at many other place. We > > used to do that in the past because we have initialized the full > > section but this has been changed recently. Pavel, do you have any ideas > > how to deal with this partial mem sections now? > > I think this is not related to the recent changes of memory initialization. > If > you mean deferred init case, the problem exists even without > CONFIG_DEFERRED_STRUCT_PAGE_INIT kernel option. This is more about struct page initialization (which doesn't clear whole) memmap area and as such it stays unitialized. So you are right this is a much older issue we just happened to not notice without explicit memmap poisoning. -- Michal Hocko SUSE Labs