Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp5663542imm; Wed, 12 Sep 2018 09:13:56 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZa2p2WRZVBInQRowYcwvFv1G5/Ap20wC7jTogKYPbOBwEjo4zekOYfhh1Kri98Kc8uotuU X-Received: by 2002:a17:902:4124:: with SMTP id e33-v6mr3164953pld.48.1536768836135; Wed, 12 Sep 2018 09:13:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536768836; cv=none; d=google.com; s=arc-20160816; b=JbGNjK1edcKbA+TNS5JTR2zhOvGzJeebZT7SYDWc2qSbThkJke0xpI5K+mXRb5KTN2 DjDQNlltGtNAb5k22PH84sSTLRV2nZ+XcBGarbZEqdgs/B9xWEllqW4g21PbavOg2KTs BYr8gjaQMjHIThDjJMEEUfFDSRyOx5iU8ieVVjCjooNEuupndg4a5f9BOI3trSHz3MGW 0G1jo0RgSrJYjgYrzQhnizw7MaAIoY2DA0Mj2oIInbKWltNs2LKpaBnbwiL0bcFEezL9 Pmls3kUHQJs50QOJLwxYb/6b9qsmxspfdoS49G5zB0TSN2IDw6DasotTItyOl3901YAh MICw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from; bh=KsWfzXeRGvhHtRWJxNsLHPbtXHgGeTvZeOrw24QZ+jQ=; b=sH9LccK3LylvdjKLhZdIZ/brgIm+2k7+GsKK7s/Ubf8kDhSsncIxncu3q5ZNZRF3nu CehJzy39pR70ie5mXpno7KomeuutCAKllwQak8gAeFEUW0ozet85Vay081fZMKnB1w19 8Af6ezkQC8yfjgp5kObXefwZrG8PVc9AddzMSEBMpy3T9+CQMgP1+X2Oi8EQJlMusJbs s+De86+wR1IMHJOn98wXr72drcEBj9h4R1uhBuLBi1ico/HrAqRAJz9Mn3K5rZRnwWy8 k4TaXghV0MYRhrJIou7ujZWlzDIHufjOjIKCdNxyXVc+IsHaLBdzKAmgilyzORCIIovc 2Tow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a143-v6si1521944pfd.241.2018.09.12.09.13.32; Wed, 12 Sep 2018 09:13:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728041AbeILVQ0 convert rfc822-to-8bit (ORCPT + 99 others); Wed, 12 Sep 2018 17:16:26 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([146.101.78.151]:55019 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726672AbeILVQ0 (ORCPT ); Wed, 12 Sep 2018 17:16:26 -0400 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-90-4yHxpl17OkaAEmZvN9gB5w-1; Wed, 12 Sep 2018 17:10:06 +0100 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b::d117) by AcuMS.aculab.com (fd9f:af1c:a25b::d117) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Wed, 12 Sep 2018 17:12:17 +0100 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Wed, 12 Sep 2018 17:12:17 +0100 From: David Laight To: 'Arnd Bergmann' , "viro@zeniv.linux.org.uk" CC: "linux-fsdevel@vger.kernel.org" , "stable@vger.kernel.org" , "Yan, Zheng" , Sage Weil , Ilya Dryomov , Chengguang Xu , "ceph-devel@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v2 04/17] ceph: fix compat_ioctl for ceph_dir_operations Thread-Topic: [PATCH v2 04/17] ceph: fix compat_ioctl for ceph_dir_operations Thread-Index: AQHUSqquiaU+csxrX0GJf2dwmCHs0KTs0QpA Date: Wed, 12 Sep 2018 16:12:17 +0000 Message-ID: <9e5f6ad82a2344c095234b39224605d4@AcuMS.aculab.com> References: <20180912150142.157913-1-arnd@arndb.de> <20180912150142.157913-4-arnd@arndb.de> In-Reply-To: <20180912150142.157913-4-arnd@arndb.de> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-MC-Unique: 4yHxpl17OkaAEmZvN9gB5w-1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann > Sent: 12 September 2018 16:01 > > The ceph_ioctl function is used both for files and directories, but only > the files support doing that in 32-bit compat mode. > > For consistency, add the same compat handler to the dir operations > as well. Have you verified that all the relevant ioctl buffer structures are exactly the same for 32bit and 64bit applications? David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)