Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20180912164510.23444-1-zsm@chromium.org>
In-Reply-To: <20180912164510.23444-1-zsm@chromium.org>
From:   Guenter Roeck <groeck@google.com>
Date:   Wed, 12 Sep 2018 09:50:16 -0700
Message-ID: <CABXOdTd4iHi5=TJymRyD9c=A+=Lj2E3sFmaUzRpMJGLkk6+ZOA@mail.gmail.com>
Subject: Re: [PATCH] perf/pt: Annotate pt_cap_group with __ro_after_init
To:     Zubin Mithra <zsm@chromium.org>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Guenter Roeck <groeck@chromium.org>,
        Kees Cook <keescook@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Sep 12, 2018 at 9:45 AM Zubin Mithra <zsm@chromium.org> wrote:
>
> pt_cap_group is written to in pt_pmu_hw_init and not modified after. This makes
> it a suitable candidate for annotating as __ro_after_init.
>
> Signed-off-by: Zubin Mithra <zsm@chromium.org>

Reviewed-by: Guenter Roeck <groeck@chromium.org>

> ---
>  arch/x86/events/intel/pt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/events/intel/pt.c b/arch/x86/events/intel/pt.c
> index 8d016ce5b80d..3a0aa83cbd07 100644
> --- a/arch/x86/events/intel/pt.c
> +++ b/arch/x86/events/intel/pt.c
> @@ -95,7 +95,7 @@ static ssize_t pt_cap_show(struct device *cdev,
>         return snprintf(buf, PAGE_SIZE, "%x\n", pt_cap_get(cap));
>  }
>
> -static struct attribute_group pt_cap_group = {
> +static struct attribute_group pt_cap_group __ro_after_init = {
>         .name   = "caps",
>  };
>
> --
> 2.18.0.597.ga71716f1ad-goog
>