Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Sasha Levin <Alexander.Levin@microsoft.com>
To:     Boris Ostrovsky <boris.ostrovsky@oracle.com>
CC:     "stable@vger.kernel.org" <stable@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        vkuznets <vkuznets@redhat.com>,
        "David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH AUTOSEL 4.18 69/88] xen-netfront: fix queue name setting
Thread-Topic: [PATCH AUTOSEL 4.18 69/88] xen-netfront: fix queue name setting
Thread-Index: AQHURkLY+K2w4GlTsE6LaL1MANj2OKTlFWCAgAfdNgA=
Date:   Wed, 12 Sep 2018 17:39:29 +0000
Message-ID: <20180912173928.GE3821@sasha-vm>
References: <20180907003547.57567-1-alexander.levin@microsoft.com>
 <20180907003547.57567-69-alexander.levin@microsoft.com>
 <5f24d66d-57d4-4424-d524-58a6d0687f02@oracle.com>
In-Reply-To: <5f24d66d-57d4-4424-d524-58a6d0687f02@oracle.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: microsoft.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-ID: <769A518D57A616489307372E555134A9@namprd21.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 75a9425d-2585-4979-17f6-08d618d6b15b
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Sep 2018 17:39:29.5937
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR21MB0283
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 07, 2018 at 01:33:55PM -0400, Boris Ostrovsky wrote:
>On 09/06/2018 08:36 PM, Sasha Levin wrote:
>> From: Vitaly Kuznetsov <vkuznets@redhat.com>
>>
>> [ Upstream commit 2d408c0d4574b01b9ed45e02516888bf925e11a9 ]
>>
>> Commit f599c64fdf7d ("xen-netfront: Fix race between device setup and
>> open") changed the initialization order: xennet_create_queues() now
>> happens before we do register_netdev() so using netdev->name in
>> xennet_init_queue() is incorrect, we end up with the following in
>> /proc/interrupts:
>>
>>  60:        139          0   xen-dyn    -event     eth%d-q0-tx
>>  61:        265          0   xen-dyn    -event     eth%d-q0-rx
>>  62:        234          0   xen-dyn    -event     eth%d-q1-tx
>>  63:          1          0   xen-dyn    -event     eth%d-q1-rx
>>
>> and this looks ugly. Actually, using early netdev name (even when it's
>> already set) is also not ideal: nowadays we tend to rename eth devices
>> and queue name may end up not corresponding to the netdev name.
>>
>> Use nodename from xenbus device for queue naming: this can't change in V=
M's
>> lifetime. Now /proc/interrupts looks like
>>
>>  62:        202          0   xen-dyn    -event     device/vif/0-q0-tx
>>  63:        317          0   xen-dyn    -event     device/vif/0-q0-rx
>>  64:        262          0   xen-dyn    -event     device/vif/0-q1-tx
>>  65:         17          0   xen-dyn    -event     device/vif/0-q1-rx
>>
>> Fixes: f599c64fdf7d ("xen-netfront: Fix race between device setup and op=
en")
>> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>> Reviewed-by: Ross Lagerwall <ross.lagerwall@citrix.com>
>> Signed-off-by: David S. Miller <davem@davemloft.net>
>> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
>
>
>You also want to pull commit 21f2706b20100bb3db378461ab9b8e2035309b5b.

Added, thanks!=