Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp29750imm; Wed, 12 Sep 2018 17:24:56 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYC2GJ1D/hFd+sK5rPTWeLL/V7y/CSNhL5X9l68xMjFKfXItdgAHoU1G0PScPcggQHkD3dj X-Received: by 2002:a65:49cc:: with SMTP id t12-v6mr4615882pgs.27.1536798296709; Wed, 12 Sep 2018 17:24:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536798296; cv=none; d=google.com; s=arc-20160816; b=tJ2r0BCnI+PaMgr+tr4G4i+lUc2QGmZglNbki+hke1o3tjSA1E5vt7QUns+KIalAp5 FjL9zoBOa6DhM+oXa1B3d2tULHVQtG7bnDKnLaR/sP/M8yamD+gEvwC4KPPGVfsjkuCH 6hupPsvZ9nD3M/nQzqN0f7g4g7tgR2jQv2s+slSFdXTpnpR6NjiK+FPpdYfTO1wV+cFO RPQUmspywWEQFla/w42AeT0SG21oisK5rBlDotcG4PfOIuJgiosCBn2WSzevLOnIQjda MVtpVzWIwM/r4fQLTiocp27nvaXPCrGcicH61aeyhxbUf8owRHNrZR7wyOMCnuDReYiZ DScg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature; bh=8ktaeWIjqwPSIh1NZQKxymzGW3ecIFfPfa3leYrdQZU=; b=roZP8db3ctnP2y8R2ufczivE57ZKqNyGTuzpxn3p0UtSqF/AmIaail2a40itaYFowB uY+7ly6gwrxbniIKIgDgOyXajpYca8tUbvl3WKpFFR+uE/dPug0cj4n8ouvWMElPtrVh 5NYh984TkPU5Z3SwcFmtwVBNN1o9q4MDemqPAUvHqtwfRtb1u6MRhNbwe8gnO/Upy1Rp uwA7wIwv9pnNC8O7Nd7kzPSjvCam/dxqIl1RI3uyuFRy4QPP3YxZxQcZ+92jmE7T8pVk FB6vSuodfxbtId1+0I1ZsRg1ZCyPMd8SubjPRKkAmwPFwYi2Rrx39dwwsUNh7CgaxDIB H5FA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="E/gBwgSe"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y13-v6si2340488pgp.560.2018.09.12.17.24.38; Wed, 12 Sep 2018 17:24:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="E/gBwgSe"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727004AbeIMFaj (ORCPT + 99 others); Thu, 13 Sep 2018 01:30:39 -0400 Received: from mail-yw1-f66.google.com ([209.85.161.66]:43381 "EHLO mail-yw1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726111AbeIMFaj (ORCPT ); Thu, 13 Sep 2018 01:30:39 -0400 Received: by mail-yw1-f66.google.com with SMTP id l189-v6so469332ywb.10 for ; Wed, 12 Sep 2018 17:23:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8ktaeWIjqwPSIh1NZQKxymzGW3ecIFfPfa3leYrdQZU=; b=E/gBwgSeA13jY1rfKYppcwV0bzp2pyeyCFmHieVvmuE7dCVTAH9tVdgtCDKdJ32+NF tf8gy7rOvtgXidqVhqb3urdtc168SkjPUTZULTwfYW+O/35aXBdkUbUxN/djOhAP722p ToRRYYCuZAik2lCQful2ORaXqcSFu29I6ONZQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=8ktaeWIjqwPSIh1NZQKxymzGW3ecIFfPfa3leYrdQZU=; b=pGWIJkzDxtUcYASdsBykAHzOeyl1E4VnRYAZ6Grz+ZepJvC6sE0tti0PBIeJAXAAPf nsAX42zBjd7HgZ5E/TTnEbhEh7Y6AtJYkNueV70TZVAHrc40MM5KiXeL4TopbDMaAbjx bLfRTguwTnppNkRfjr0mMikFk296dlec988+T6looPUBdes94vNUSSpwwHPFBiSYWkeu bdWEdOaS97fZkvfwuWdH1dVy1gsKJ17UvFWFq/TP/bzY1Xzc9k+Kx1h6dBNidcydpudJ 2FmGFBqogwqpnFzSMkJ1yrFinI7VEkHB8KI8Fd+Qbobk9scaAyz3bHl4dwQT1v+0I9Zi OVMw== X-Gm-Message-State: APzg51B0G4mbmWDnP0eBIwficFSCwxPV06gDbw7109jCEGKv/e/DirLO wVf2kup4au9mVQWW6ymmNVBE2AL4gAU= X-Received: by 2002:a81:7d46:: with SMTP id y67-v6mr2315731ywc.457.1536798221823; Wed, 12 Sep 2018 17:23:41 -0700 (PDT) Received: from mail-yw1-f51.google.com (mail-yw1-f51.google.com. [209.85.161.51]) by smtp.gmail.com with ESMTPSA id k184-v6sm817375ywc.62.2018.09.12.17.23.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Sep 2018 17:23:40 -0700 (PDT) Received: by mail-yw1-f51.google.com with SMTP id l189-v6so469312ywb.10 for ; Wed, 12 Sep 2018 17:23:40 -0700 (PDT) X-Received: by 2002:a81:9b85:: with SMTP id s127-v6mr2232916ywg.47.1536798220268; Wed, 12 Sep 2018 17:23:40 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:5f04:0:0:0:0:0 with HTTP; Wed, 12 Sep 2018 17:23:39 -0700 (PDT) In-Reply-To: <1aa12afc-2e1e-2e89-d422-a471990e0367@schaufler-ca.com> References: <1aa12afc-2e1e-2e89-d422-a471990e0367@schaufler-ca.com> From: Kees Cook Date: Wed, 12 Sep 2018 17:23:39 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 07/10] SELinux: Abstract use of inode security blob To: Casey Schaufler Cc: LSM , James Morris , LKLM , SE Linux , John Johansen , Tetsuo Handa , Paul Moore , Stephen Smalley , "linux-fsdevel@vger.kernel.org" , Alexey Dobriyan , "Schaufler, Casey" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 11, 2018 at 9:42 AM, Casey Schaufler wrote: > Don't use the inode->i_security pointer directly. > Provide a helper function that provides the security blob pointer. > > Signed-off-by: Casey Schaufler Happily mechanical! :) Reviewed-by: Kees Cook -Kees -- Kees Cook Pixel Security