Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] power_supply: sysfs: ratelimit property read error
 message
To:     Sebastian Reichel <sre@kernel.org>, linux-pm@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org
References: <20180913004830.1265-1-david@lechnology.com>
From:   David Lechner <david@lechnology.com>
Message-ID: <fa60b825-cd9e-91d7-c422-ee3b147d68c1@lechnology.com>
Date:   Wed, 12 Sep 2018 19:51:03 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180913004830.1265-1-david@lechnology.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 09/12/2018 07:48 PM, David Lechner wrote:
> This adds ratelimiting to the message that is printed when reading a
> power supply property via sysfs returns an error. This will prevent
> userspace applications from unintentionally dDOSing the system by
> continuosuly reading a property that returns an error.

s/continuosuly/continuously/

> 
> Signed-off-by: David Lechner <david@lechnology.com>
> ---
>   drivers/power/supply/power_supply_sysfs.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
> index 6170ed8b6854..dce24f596160 100644
> --- a/drivers/power/supply/power_supply_sysfs.c
> +++ b/drivers/power/supply/power_supply_sysfs.c
> @@ -131,7 +131,8 @@ static ssize_t power_supply_show_property(struct device *dev,
>   				dev_dbg(dev, "driver has no data for `%s' property\n",
>   					attr->attr.name);
>   			else if (ret != -ENODEV && ret != -EAGAIN)
> -				dev_err(dev, "driver failed to report `%s' property: %zd\n",
> +				dev_err_ratelimited(dev,
> +					"driver failed to report `%s' property: %zd\n",
>   					attr->attr.name, ret);
>   			return ret;
>   		}
>