Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20180907165635.8469-1-kent.overstreet@gmail.com>
 <20180907165635.8469-4-kent.overstreet@gmail.com> <89c167ff-91d3-7a27-78c6-82710bb11771@I-love.SAKURA.ne.jp>
 <20180907175014.GA29485@kmo-pixel>
In-Reply-To: <20180907175014.GA29485@kmo-pixel>
From:   Paul Moore <paul@paul-moore.com>
Date:   Wed, 12 Sep 2018 22:27:40 -0400
Message-ID: <CAHC9VhS=CaEd4quGRv97Dn_2gm7=jMq+nHJvSOnuBtoA=DZvDQ@mail.gmail.com>
Subject: Re: [PATCH 3/6] selinux: convert to kvmalloc
To:     kent.overstreet@gmail.com, selinux@tycho.nsa.gov
Cc:     penguin-kernel@i-love.sakura.ne.jp, linux-kernel@vger.kernel.org,
        dave.hansen@intel.com, willy@infradead.org,
        linux-security-module@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Sep 7, 2018 at 1:50 PM Kent Overstreet
<kent.overstreet@gmail.com> wrote:
> On Sat, Sep 08, 2018 at 02:08:03AM +0900, Tetsuo Handa wrote:
> > On 2018/09/08 1:56, Kent Overstreet wrote:
> > > @@ -329,8 +328,7 @@ int avtab_alloc(struct avtab *h, u32 nrules)
> > >             nslot = MAX_AVTAB_HASH_BUCKETS;
> > >     mask = nslot - 1;
> > >
> > > -   h->htable = flex_array_alloc(sizeof(struct avtab_node *), nslot,
> > > -                                GFP_KERNEL | __GFP_ZERO);
> > > +   h->htable = kvmalloc_array(nslot, sizeof(void *), GFP_KERNEL);
> > >     if (!h->htable)
> > >             return -ENOMEM;
> > >
> >
> > kvmalloc_array() does not imply __GFP_ZERO.
>
> Thanks, fixed

When you resubmit this patch, please make sure you submit it to the
SELinux list (added to the To line above) so that it can be properly
reviewed and merged.

Thanks.

-- 
paul moore
www.paul-moore.com