Date: Tue, 11 Nov 2003 14:41:31 -0800
From: "Martin J. Bligh" <mbligh@aracnet.com>
To: Anton Blanchard <anton@samba.org>, Linus Torvalds <torvalds@osdl.org>
cc: Erik Jacobson <erikj@subway.americas.sgi.com>,
       linux-kernel@vger.kernel.org
Subject: Re: 2.6 /proc/interrupts fails on systems with many CPUs
Message-ID: <31250000.1068590491@flay>
In-Reply-To: <20031111201458.GS930@krispykreme>
References: <9710000.1068573723@flay> <Pine.LNX.4.44.0311111019210.30657-100000@home.osdl.org> <20031111201458.GS930@krispykreme>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1035
Lines: 29

>> There are basically no valid new uses of it. There's a few valid legacy
>> users (I think the file descriptor array), and there are some drivers that
>> use it (which is crap, but drivers are drivers), and it's _really_ valid
>> only for modules. Nothing else.
> 
> The IPC code is doing ugly things too:
> 
> void* ipc_alloc(int size)
> {
>         void* out;
>         if(size > PAGE_SIZE)
>                 out = vmalloc(size);
>         else
>                 out = kmalloc(size, GFP_KERNEL);
>         return out;
> }

That seems particularly .... odd ... as PAGE_SIZE isn't anywhere near the
breakpoint. Worst case (and I know I'll get yelled at for this, but I'll
get another amusing analogy out of Linus ;-)) we should just call kmalloc
and if it fails, then try vmalloc ...

M.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/