Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <cover.1536517047.git.lukas@wunner.de> <f53ea40a7487e145aa1a62c347cef1814072e140.1536517047.git.lukas@wunner.de>
 <20180910094454.GJ14465@lahna.fi.intel.com>
In-Reply-To: <20180910094454.GJ14465@lahna.fi.intel.com>
From:   Yehezkel Bernat <yehezkelshb@gmail.com>
Date:   Thu, 13 Sep 2018 12:43:03 +0300
Message-ID: <CA+CmpXtUHwu97tA6bTDJKbVyiPrYT0aEWr1SGrP88DFKNybEcA@mail.gmail.com>
Subject: Re: [PATCH 4/5] thunderbolt: Correlate PCI devices with Thunderbolt ports
To:     Mika Westerberg <mika.westerberg@linux.intel.com>
Cc:     lukas@wunner.de, Andreas Noever <andreas.noever@gmail.com>,
        michael.jamet@intel.com, stephen@networkplumber.org,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Sep 10, 2018 at 12:45 PM Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
>
> Hi Lukas,
>
> On Sun, Sep 09, 2018 at 11:42:01PM +0200, Lukas Wunner wrote:
> > Ideas what we can do with correlation:
> >
> > * Represent the relationship between PCI devices and Thunderbolt ports
> >   with symlinks in sysfs.
>
> I wonder is that really useful? I don't think we should be adding sysfs
> entries without any real reason why it would be needed and who would be
> using them.

I think Lukas mentioned where it can be useful, even if it isn't used right now.
We also know this can be useful for some QoS configurations (even if we didn't
found it useful enough for now).


Lukas,
What I'd like to ask is: if your point is mainly for OS-controlled tunneling
management, I'd hope this future Connection Manager will have better ways to
determine the assigned PCI bus number of the PCI devices it tunnels than the
walk over the PCI tree the current patch does. Isn't it?