Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 13 Sep 2018 12:57:53 +0300
From:   Mika Westerberg <mika.westerberg@linux.intel.com>
To:     Yehezkel Bernat <yehezkelshb@gmail.com>
Cc:     lukas@wunner.de, Andreas Noever <andreas.noever@gmail.com>,
        michael.jamet@intel.com, stephen@networkplumber.org,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] thunderbolt: Correlate PCI devices with Thunderbolt
 ports
Message-ID: <20180913095753.GF14465@lahna.fi.intel.com>
References: <cover.1536517047.git.lukas@wunner.de>
 <f53ea40a7487e145aa1a62c347cef1814072e140.1536517047.git.lukas@wunner.de>
 <20180910094454.GJ14465@lahna.fi.intel.com>
 <CA+CmpXtUHwu97tA6bTDJKbVyiPrYT0aEWr1SGrP88DFKNybEcA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+CmpXtUHwu97tA6bTDJKbVyiPrYT0aEWr1SGrP88DFKNybEcA@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Sep 13, 2018 at 12:43:03PM +0300, Yehezkel Bernat wrote:
> On Mon, Sep 10, 2018 at 12:45 PM Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> >
> > Hi Lukas,
> >
> > On Sun, Sep 09, 2018 at 11:42:01PM +0200, Lukas Wunner wrote:
> > > Ideas what we can do with correlation:
> > >
> > > * Represent the relationship between PCI devices and Thunderbolt ports
> > >   with symlinks in sysfs.
> >
> > I wonder is that really useful? I don't think we should be adding sysfs
> > entries without any real reason why it would be needed and who would be
> > using them.
> 
> I think Lukas mentioned where it can be useful, even if it isn't used right now.
> We also know this can be useful for some QoS configurations (even if we didn't
> found it useful enough for now).

I have no doubts that is not useful :) The issue is that currently it
does not do anything except adds this functionality to the driver but
nobody uses it. Like in the other parts of the kernel, let's merge this
at the same time when there is a legitimate user for the feature.