Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp546521imm; Thu, 13 Sep 2018 04:09:36 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaOiEypg2UbeHE7KffBcwRktGSGGtj+xHVl3R1JWb0V8iPBCvIWU3CKVzXwYIH8kuSN3Ep+ X-Received: by 2002:a17:902:bd07:: with SMTP id p7-v6mr6715842pls.32.1536836976412; Thu, 13 Sep 2018 04:09:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536836976; cv=none; d=google.com; s=arc-20160816; b=nAsfx/USaihHNTJNxPIoNkYCY7aFt4ZWqclwv16K8LirsaRZIQpjjTwG3CK+8LjcRt HA1AsNpF0wCs7sejcnLCYBjso/VaCj5VjTVgCJOUJGWw7PKXg3uV0gQKCYmv6auhta2n lnMskNsWxOjnipCJnDZFEIJOicwEclgbL+owt6CgMoLWiXv5SX9wP67W3igAKZY8Y5Ql 7FHAlFGQavQI8ZQfzMYdXhDU30tMNs96AS6TCNfP7anURfkIQsVqTp/N8bsG79hAp7zs 7V0Qt8tSM8RJIJVr1a/ZqBELzTvNeJFlL10GAJjvCmkLSqiQIXH+Khor669gOLyszqk5 VFaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:cms-type:message-id :content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:from:cc:to:subject:dkim-signature:dkim-filter; bh=H04Tj1ryn3rcXGl9E1Ay33D8/6C4zmV0cllpcAVGlqA=; b=B1WtPvYfjIz3afoPMQQDwhwtdZtr2lFGOV1ho1fw3PBXSXe4ipl05rYu7czj7JzBRZ 2xbZXJZzflLaGef9i5veB0rHHUeUyUoIWUYsHbUzRoSfN1A1pY4JGAkvc0bW5Y72NDr3 OJ4O+ab+gVShCZZlt4TDfOQRP+6DOmbuTUXfNIsEtsq9682nLRONakOdj2Or6D+PoN1P pIUUzNl5IcKcpjX0JFD9532hdIxGFgzAjy6fl4yyuw6eKHvQlWhY78oFs80iJlHxKu9I PmoqwMozzTEE3GqRIzfKy65six4ihV78SQ6IkMatjg7Y102wIZeybyP7qspKl8nH4Jmd Hbyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=MbA2Hvjm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g65-v6si4194478plb.297.2018.09.13.04.09.19; Thu, 13 Sep 2018 04:09:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=MbA2Hvjm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727592AbeIMQRc (ORCPT + 99 others); Thu, 13 Sep 2018 12:17:32 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:41021 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726821AbeIMQRc (ORCPT ); Thu, 13 Sep 2018 12:17:32 -0400 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20180913110832euoutp017db7532b63765ad0927fae6e764bb6af~T8QdzUi3s0449604496euoutp01Y for ; Thu, 13 Sep 2018 11:08:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20180913110832euoutp017db7532b63765ad0927fae6e764bb6af~T8QdzUi3s0449604496euoutp01Y DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1536836912; bh=H04Tj1ryn3rcXGl9E1Ay33D8/6C4zmV0cllpcAVGlqA=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=MbA2HvjmZZNRoCkzUkaRvGL5R+a8eoNPbKXCtsKXRO+KuFdIlOeGPZe3rjLvzK8Hf GmdLX8knj27UnTyVJrsSJHdE7Ocr/pp15o7vWEpETootWmagJIMBaQdp0F9KOumNZD 8OlqOF+kIbkBrigFlZAvYCRd5N2RJlN2/x99QYJs= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20180913110830eucas1p1e48320b0ecc36954d0bf77758925b73e~T8QcdOs7n2956029560eucas1p1h; Thu, 13 Sep 2018 11:08:30 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id E2.AE.04441.E254A9B5; Thu, 13 Sep 2018 12:08:30 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20180913110829eucas1p2de1f7f14c8dcf186d4b829c22920365e~T8Qbh1iEV3205832058eucas1p2W; Thu, 13 Sep 2018 11:08:29 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20180913110829eusmtrp12638a5da7a26df901b160b9afdcbd7a6~T8QbP_LcF2361723617eusmtrp1k; Thu, 13 Sep 2018 11:08:29 +0000 (GMT) X-AuditID: cbfec7f2-5c9ff70000001159-ef-5b9a452e615d Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 4F.85.04284.D254A9B5; Thu, 13 Sep 2018 12:08:29 +0100 (BST) Received: from [106.120.43.17] (unknown [106.120.43.17]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20180913110828eusmtip18b880975b9c8b51b563ab8b9fe2a44e1~T8QaYmIcK0182501825eusmtip1U; Thu, 13 Sep 2018 11:08:28 +0000 (GMT) Subject: Re: [PATCH v3 2/5] drm/dp: fix link probing for devices supporting DP 1.4+ To: Damian Kos , David Airlie , Rob Herring , Mark Rutland , Archit Taneja , Laurent Pinchart , Gustavo Padovan , Maarten Lankhorst , Sean Paul , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Quentin Schulz , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Cc: pgaj@cadence.com, ltyrala@cadence.com, stelford@cadence.com, jartur@cadence.com, piotrs@cadence.com From: Andrzej Hajda Date: Thu, 13 Sep 2018 13:08:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1535451894-2518-3-git-send-email-dkos@cadence.com> Content-Transfer-Encoding: 8bit Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA01SaUhUURjlvm2e0thzNOejxWgoQiPLaLlRhEHBoyKtEEx/5JQvNdfmuWQR bVQuabmUzmhjYWbZSDluNbmEDY17LmULhUNqkJNFmVaWLeMz8t+555zv+86By5IKPTObDY+O EzTR6kgV40hVP/resdRrsy5oeWmGG07vaCbwyeRhGheaO2j8um81fjL6kcH3rCYZ/v3GRuPL WUdx/tNahFMyr8mwsb+Xxj2mAgZ/tv4m8dsfK/DVT1UULn7WReD65xcpfENfgXB5Qz2NT9eZ Zfh1thnh9wMG5OPGG/QGxOsNR3hDio3gezLSCT4/WUvzxtIUhq8Zs9K8vnkH35dmIfiKa8f4 e1l1BG8xvZTxE7oGiq/p1ZP8iNHdb2ag4/oQITI8QdAs2xDsGNYx6Bs7wh5qMQrHkUmWihxY 4FZCW984SkWOrIK7geBOihbZBQX3BcGP1mBJGEHQ9lRL/JsYOmUhJaEEwbfT7TLpMYxgsPzE 5LgL5w9fa3spu+DK6WjonshnUhHLklw4XGo7aPcwnAdMVLyYpCluEaRp59npWVwAmK1XJ9fI OWdo1g5QduzA+UB6TydtxyQ3H05V5ZMSVsLLgULCfgo4KwuN3wYJaTgBam0FlJR6E9iyM6c6 u8CQpXIKz4XW7HNTnmNwUvuElBYlI2gqKmEkYR08tHTRUn4PuG1aJtEb4exwO2mngXOC58PO Uh4nyKrOnaLlkHxGIbkXQF97FSlhJRR3jjIXkEo3raVuWjPdtGa6/3evIKoUKYV4MSpUEL2j hUQvUR0lxkeHeu2LiTKiv7+29Zfl81002r23EXEsUs2Q5y3WBilodYKYFNWIgCVVrvLzProg hTxEnXRY0MTs0cRHCmIjmsNSKqXcyXN/kIILVccJEYIQK2j+qQTrMPs4Ki12mzk41vLKtvBn ka3IP3FL5f3rvf7teajfIaP6fdlY2e766gOVrmHFZIhvgF/5u8zEF167KDfBLzdx/GFNbs7c nIY2bULErTrftTFbjdvcH6xRFn543B84v0RMi+u52VyWHTq0aqG4acv9nXjk6GFzQM7ST0fy nP3cZU3b69KXeKooMUzt7UlqRPUfP5BkqbEDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA02Se0hTcRTH+927u12l4W2a/pAeckHsoVt3pvsZJUJEvxB6Ej0kauhFLeds d1aWPdSE1EydSWyrrXdRg3DDZ2nhk5VZaloNRE17aRZlVmJp6gr878v5nM85HDg0KXNQ/nRi sp7XJauTWLGn6MlEc3dIyDpTzIqCCW+U3+okUOaZYQpZG1op1N0Tjl6MfhGjqt5qCZp8M0Sh S4bjyNz5AKCcousSZO/volBH9UUx+tY7SaJ340p05WuZCN142Uag2lclInTb4gCo9GEthbJr GiSou7gBoE8DNhDli20WG8AW2zFsyxkicMe5fAKbzxgpbL+TI8YVP3opbHFuwT15zQR2XD+J qww1BG6udknwH9NDEa7ospB4xL5os9du+WqdNlXPByRoBf0aNoZDSjkXgeTKlRFyLlS1Z5Uy jFVEro7jkxIP8TpF5D55QuvbTSkj9JHHdv4UqJbkAg8aMivhYFYzmQs8aRlzA8Cb/UOEG/jB +9Zh0p294e+uXLG7aQjAJ64i0TTwZrbDQfPjGeDDWCjYcvrjDCCZRHhl5JfEbTgBPD8+CKaB mFkK/zhei6ezlImEpYWuqXU0LWICYZ5x4XR5PrMT3r31gXK3zINO48DMTA8mCuZ3PKfc84Pg b0s76c6LYVaZ+V/2g64BK1EIZKZZummWYpqlmGYpl4HoDvDhUwVNvEbg5IJaI6Qmx8tjtRo7 mHqY8qYxRyVoL91WBxgasHOlH1hjjIxSHxLSNHUA0iTrIy2IMsXIpHHqtKO8TrtXl5rEC3Ug bOq2ItJ/fqx26v2S9Xu5ME6FIjhVqCo0HLF+0mcr0nbLmHi1nj/A8ym87r9H0B7+p0BwXu3o iQVk0JK6ls6SbF9pZXwADrxQxWXuKFTMubb1c99R83tjyl3G0JHu+eha46MNB89O9NXbitMl hqJt+qYMm6Hk9fKBEm0cfXXMhYO+R61fa914+Gd9r5czQcW2gX5l9P722qe2vvpd+onoL9Z7 HpW3yhVZGZ8UwRpLI72LFQkJam4ZqRPUfwFEO99+RgMAAA== Message-Id: <20180913110829eucas1p2de1f7f14c8dcf186d4b829c22920365e~T8Qbh1iEV3205832058eucas1p2W@eucas1p2.samsung.com> X-CMS-MailID: 20180913110829eucas1p2de1f7f14c8dcf186d4b829c22920365e X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20180828102609epcas4p4946d20a22c2ccc6b6157dd9ca954db70 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180828102609epcas4p4946d20a22c2ccc6b6157dd9ca954db70 References: <1535451894-2518-1-git-send-email-dkos@cadence.com> <1535451894-2518-3-git-send-email-dkos@cadence.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.08.2018 12:24, Damian Kos wrote: > From: Quentin Schulz > > DP 1.4 introduced a DP_EXTENDED_RCVR_CAPA_FIELD_PRESENT bit in > DP_TRAINING_AUX_RD_INTERVAL register. If set, DPCD registers from DP_DPCD_REV > to DP_ADAPTER_CAP should be retrieved starting from DP_DPCD_REV_EXTENDED. > All registers are copied except DP_DPCD_REV, DP_MAX_LINK_RATE and > DP_DOWNSTREAMPORT_PRESENT which represent the "true capabilities" of DPRX > device. > > Original DP_DPCD_REV, DP_MAX_LINK_RATE and DP_DOWNSTREAMPORT_PRESENT might > falsely return lower capabilities to "avoid interoperability issues with some > of the existing DP Source devices that malfunction when they discover the > higher capabilities within those three registers.". > > Before DP 1.4, DP_EXTENDED_RCVR_CAPA_FIELD_PRESENT bit was reserved and read 0 > so it's safe to check against it even if DP revision is <1.4 > > Signed-off-by: Damian Kos Here and in next patches signed-off-by of the author is missing. With that fixed: Reviewed-by: Andrzej Hajda  -- Regards Andrzej