Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp727724imm; Thu, 13 Sep 2018 06:55:26 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZboW3FseTDCS3P233vWy0WFftDlj94g3/KSMK0It90nsSbqsmGAaVTX7/PEOxP2zylUNDc X-Received: by 2002:aa7:88d3:: with SMTP id p19-v6mr7649352pfo.160.1536846926844; Thu, 13 Sep 2018 06:55:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536846926; cv=none; d=google.com; s=arc-20160816; b=Pv3NbmFdnFb4EHrG9RB1J0kOaU2TDyG8LrCR7dWNC8QTUr7PXgkTLawBP+0oW8QnvX XeTN/RRYjZ+wMJsXPipJ8I4wxwf9IFi+Gybue8YUdGuvkckzcLAJhuFIF5f9lNEVr724 4oQu+NSOMXXvTn0GHa668bGdaW/z4V/72I4tg0F0Y1VFqpVRU/9/fJ+F+Xo6kzNAT1IO PZm+YF6XUz2u4AmRSH4mtwCQJOY+1JrHvTHTf9kzmEcoUL8AtQDD68qmWa25u+Hjchj1 WOK83aYpnLWbgkj8AxaDdwtcbB6miv6yxMVdAmFKb6ynlZpiTWDz/r8oWM1UOCraWihi 9ojg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from; bh=ND4cjXOdogmzfm5IS+D/zgteEa80etvEbcFVeb2Ds7I=; b=dRiuldSvYJvLXrwc6L2USZdgLJn5vB6lGvs4ecejb5RnXHZf9QFP2KAHRuvhRLCLRB I+WYlFJJxVY3eLPITkXYnyF0XFoorXy8j0MrMRTfbRqVv8iY7hjOpCjAqpIQwgjiKZuW UrscsJ+rONn/VXMwDbU7g6ZyuAlZB8ZFQgzTRE+6O+69G/Dl6PM1GsnOB7EI3ARR0243 mjuLpmQkgdt14dqrLnj2P4JvWYaV3etjyYSHG9MT+9JOSd2K1RaO95aSyd9JDX5t8KBx n36Ily25MS2zD2ETPk61UXbEjYdA+M5XzVTT/8pMts5VnhSub2JvruM+xkc4ZmZN75r7 Pswg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o20-v6si4528378pgb.608.2018.09.13.06.55.11; Thu, 13 Sep 2018 06:55:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731166AbeIMTD1 (ORCPT + 99 others); Thu, 13 Sep 2018 15:03:27 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33750 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728810AbeIMTD1 (ORCPT ); Thu, 13 Sep 2018 15:03:27 -0400 Received: from localhost (ip-213-127-77-73.ip.prioritytelecom.net [213.127.77.73]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 1F00DD19; Thu, 13 Sep 2018 13:53:50 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jerome Brunet , Neil Armstrong , Thierry Reding , Sasha Levin Subject: [PATCH 4.18 057/197] pwm: meson: Fix mux clock names Date: Thu, 13 Sep 2018 15:30:06 +0200 Message-Id: <20180913131843.804736565@linuxfoundation.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20180913131841.568116777@linuxfoundation.org> References: <20180913131841.568116777@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jerome Brunet [ Upstream commit b96e9eb62841c519ba1db32d036628be3cdef91f ] Current clock name looks like this: /soc/bus@ffd00000/pwm@1b000#mux0 This is bad because CCF uses the clock to create a directory in clk debugfs. With such name, the directory creation (silently) fails and the debugfs entry end up being created at the debugfs root. With this change, the clock name will now be: ffd1b000.pwm#mux0 This matches the clock naming scheme used in the ethernet and mmc driver. It also fixes the problem with debugfs. Fixes: 36af66a79056 ("pwm: Convert to using %pOF instead of full_name") Signed-off-by: Jerome Brunet Acked-by: Neil Armstrong Signed-off-by: Thierry Reding Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/pwm/pwm-meson.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/pwm/pwm-meson.c +++ b/drivers/pwm/pwm-meson.c @@ -458,7 +458,6 @@ static int meson_pwm_init_channels(struc struct meson_pwm_channel *channels) { struct device *dev = meson->chip.dev; - struct device_node *np = dev->of_node; struct clk_init_data init; unsigned int i; char name[255]; @@ -467,7 +466,7 @@ static int meson_pwm_init_channels(struc for (i = 0; i < meson->chip.npwm; i++) { struct meson_pwm_channel *channel = &channels[i]; - snprintf(name, sizeof(name), "%pOF#mux%u", np, i); + snprintf(name, sizeof(name), "%s#mux%u", dev_name(dev), i); init.name = name; init.ops = &clk_mux_ops;