Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp730043imm; Thu, 13 Sep 2018 06:57:37 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaWVwgGv6k5qDP/+4p6IsDzeVy0voW/PWZMt1GZXpoLytcQc0XsG2X/SF5ThvENcCxMVVyc X-Received: by 2002:a62:3a08:: with SMTP id h8-v6mr7615640pfa.61.1536847057778; Thu, 13 Sep 2018 06:57:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536847057; cv=none; d=google.com; s=arc-20160816; b=EC89cLEAwKMbVDQGowX9oEjFHfWQMr6uMc3kXdW3xaV252AzaKpzeIxETgrfw58Hxd BCHvfgdyjAkYfkIOxR1clG/xWgnPX6wj21BoxfCDlnUWXEuKrs/N+iI1m2a1kAOP89FY 62C0acEJL1PU9o8U3S0o4neN8BRKs8b5MUQCDpJ6Z0KUxuY7I/o27jAoon67WvTwEjY6 AM9y5/towOWsH72+bTS1xb/nDyIbgd2HUOirYHF7yrQXOceiKH6Rbv/6Y34HI6tU3vy3 DPnvkgnCS5ULUeuAIWvFvMOWk27Euqpp5p42BxP/RTOu02WzbeaWxhz4f6AyN4qwJ6JL InHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from; bh=bBgRygd59yesbXBWVv/Q8vinmEfsnUc/RN+T9xbbJjQ=; b=nfbejTTUHAtgJWblLxINb9odh1MlFp7c0eGQ07hVwlD99z1f+TcKOlhjnlN7UGl9PO bnglNtjhj1MAdCWn1YAWbN0xyR3BnAmvN1YdHMvjQ6rI7x4Eiev4bnHwz12SNYdldEjh 09iS3Xypdg5b5oYIB3kEx/MbWl/IrCaavcaSJLUI+1+jMpOQoZjRIqTINaFj4ZfqLlxq SrD5S60QcA0iFOCddrQp/kMeb/dsIZIeaNVGCyClKxf9TnYcVGecSFG95sHCzLux3Cfp itvQUBfa8gTdpSAm+MeXa52FKYK0Hpi8OSR5gbawCAab0/cLPU6nxPbCTUCtriGjOJ9s 5/2g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 64-v6si3858341plk.257.2018.09.13.06.57.22; Thu, 13 Sep 2018 06:57:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731305AbeIMTFb (ORCPT + 99 others); Thu, 13 Sep 2018 15:05:31 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34070 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730731AbeIMTFb (ORCPT ); Thu, 13 Sep 2018 15:05:31 -0400 Received: from localhost (ip-213-127-77-73.ip.prioritytelecom.net [213.127.77.73]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 978DDCE7; Thu, 13 Sep 2018 13:55:54 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Guenter Roeck , Lee Jones , Sasha Levin Subject: [PATCH 4.18 072/197] mfd: sm501: Set coherent_dma_mask when creating subdevices Date: Thu, 13 Sep 2018 15:30:21 +0200 Message-Id: <20180913131844.407160054@linuxfoundation.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20180913131841.568116777@linuxfoundation.org> References: <20180913131841.568116777@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guenter Roeck [ Upstream commit 2f606da78230f09cf1a71fde6ee91d0c710fa2b2 ] Instantiating the sm501 OHCI subdevice results in a kernel warning. sm501-usb sm501-usb: SM501 OHCI sm501-usb sm501-usb: new USB bus registered, assigned bus number 1 WARNING: CPU: 0 PID: 1 at ./include/linux/dma-mapping.h:516 ohci_init+0x194/0x2d8 Modules linked in: CPU: 0 PID: 1 Comm: swapper Tainted: G W 4.18.0-rc7-00178-g0b5b1f9a78b5 #1 PC is at ohci_init+0x194/0x2d8 PR is at ohci_init+0x168/0x2d8 PC : 8c27844c SP : 8f81dd94 SR : 40008001 TEA : 29613060 R0 : 00000000 R1 : 00000000 R2 : 00000000 R3 : 00000202 R4 : 8fa98b88 R5 : 8c277e68 R6 : 00000000 R7 : 00000000 R8 : 8f965814 R9 : 8c388100 R10 : 8fa98800 R11 : 8fa98928 R12 : 8c48302c R13 : 8fa98920 R14 : 8c48302c MACH: 00000096 MACL: 0000017c GBR : 00000000 PR : 8c278420 Call trace: [<(ptrval)>] usb_add_hcd+0x1e8/0x6ec [<(ptrval)>] _dev_info+0x0/0x54 [<(ptrval)>] arch_local_save_flags+0x0/0x8 [<(ptrval)>] arch_local_irq_restore+0x0/0x24 [<(ptrval)>] ohci_hcd_sm501_drv_probe+0x114/0x2d8 ... Initialize coherent_dma_mask when creating SM501 subdevices to fix the problem. Fixes: b6d6454fdb66f ("mfd: SM501 core driver") Signed-off-by: Guenter Roeck Signed-off-by: Lee Jones Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/mfd/sm501.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/mfd/sm501.c +++ b/drivers/mfd/sm501.c @@ -715,6 +715,7 @@ sm501_create_subdev(struct sm501_devdata smdev->pdev.name = name; smdev->pdev.id = sm->pdev_id; smdev->pdev.dev.parent = sm->dev; + smdev->pdev.dev.coherent_dma_mask = 0xffffffff; if (res_count) { smdev->pdev.resource = (struct resource *)(smdev+1);