Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp741096imm; Thu, 13 Sep 2018 07:06:06 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYnrppaV9D11KgRem2VfKyAidSGEvlPwxaKXYPFmyf9V0xv1xzZKoiD+dpZpaSzG/wLClla X-Received: by 2002:a17:902:304:: with SMTP id 4-v6mr7559021pld.39.1536847566335; Thu, 13 Sep 2018 07:06:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536847566; cv=none; d=google.com; s=arc-20160816; b=WjC33GrX/g4vCxdjy1FsMpSesYNBsrvzIcHiAUQFtuSplC1o7weje/EnwMC4U/waTd yL0XduHtHR4S0uIohhmxD7SUnu5QJb9PpaQAC50povNmvMRwBrhG0lY6UKE4pIIpHRI8 fQLHH9Y0MFZdssVEzXcIIRn+naA1nOzANNe2UYl4Z2yG8+xSl/VkdGb9xKG7bPxSK2Hi VfP3qjBs8RQb/u/ITHKPOFjxDgeXBPGtPyQVF8LFjihMyxVWt235l377WGjPss63UCNZ 5PPVV3PNNXO16HWLG8HsCYFp4ngCKioTBGBtIQF18wf9MzjXY2OLr7xf6bCRrG7xat6u p/DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from; bh=dFCbEk0E1LlHs6AbHFomIr1231h+Q25Rn3G+tU2Sg90=; b=vOZzjwuVhIO+ETe+aCuE9q5+RkipoTeoa1L0CN9n0/anvqihNwxuj2zqenadrFRIHs 4s7JSY4YqxSaXpcqEzu7WAY8w1gncVpSDro67bK0Bu9vrJEeHeQywhhUFq86EdGv0dH/ 8s5WttsoKjILOeNiisa+sUaS3164lC/u+g010ot/oMUvtXABc0tz8Vf72h/6dM4HgUhL sAgmLAw+0Icz+yp6s8oLZKa0Rq0VaHsLuashrEh8ztN/ciaTRx13Tjy12zn9Yde8eP6k EX+tDBKlEdDpNIQh+4VM02T9JxhsckUWKyeoZKOGfIAXV1EKhBLYZAbYATnWhuQilJo2 5ehg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d128-v6si4310767pfc.211.2018.09.13.07.05.46; Thu, 13 Sep 2018 07:06:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732067AbeIMTNb (ORCPT + 99 others); Thu, 13 Sep 2018 15:13:31 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:35346 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728556AbeIMTNa (ORCPT ); Thu, 13 Sep 2018 15:13:30 -0400 Received: from localhost (ip-213-127-77-73.ip.prioritytelecom.net [213.127.77.73]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 8AB47D32; Thu, 13 Sep 2018 14:03:51 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Leo (Sunpeng) Li" , Mikita Lipski , Bhawanpreet Lakha , Alex Deucher Subject: [PATCH 4.18 167/197] drm/amd/display: Use requested HDMI aspect ratio Date: Thu, 13 Sep 2018 15:31:56 +0200 Message-Id: <20180913131848.237358083@linuxfoundation.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20180913131841.568116777@linuxfoundation.org> References: <20180913131841.568116777@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Leo (Sunpeng) Li commit e11d41472a50742c16d53c968e143fb498fa482f upstream. [Why] The DRM mode's HDMI picture aspect ratio field was never saved in dc_stream's timing struct. This causes us to mistake a new stream to have the same timings as the old, even though the user has requested a different aspect ratio. [How] Save DRM's aspect ratio field within dc_stream's timing struct. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=107153 Signed-off-by: Leo (Sunpeng) Li Reviewed-by: Mikita Lipski Acked-by: Bhawanpreet Lakha Signed-off-by: Alex Deucher Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -2124,13 +2124,8 @@ convert_color_depth_from_display_info(co static enum dc_aspect_ratio get_aspect_ratio(const struct drm_display_mode *mode_in) { - int32_t width = mode_in->crtc_hdisplay * 9; - int32_t height = mode_in->crtc_vdisplay * 16; - - if ((width - height) < 10 && (width - height) > -10) - return ASPECT_RATIO_16_9; - else - return ASPECT_RATIO_4_3; + /* 1-1 mapping, since both enums follow the HDMI spec. */ + return (enum dc_aspect_ratio) mode_in->picture_aspect_ratio; } static enum dc_color_space