Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp741660imm; Thu, 13 Sep 2018 07:06:28 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZ+VkzT3QFIGGY1TkNgAL2Zs7avZKEdWZ0Ab7d6DtDuFpvlfkUPehnmhPTMuPnZ1LepoA/u X-Received: by 2002:a62:c008:: with SMTP id x8-v6mr7647617pff.149.1536847588558; Thu, 13 Sep 2018 07:06:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536847588; cv=none; d=google.com; s=arc-20160816; b=qqdGT3AE7LfGvudpKCp2OZDojIALvAh/l4nMDRBCkvxQD2UhpkjwA/n71OBqtcLwNU PZ5AAMqnzOSLqDpX8N+I6MtlrEFmRWzweqbY66QxHCGxnLJL1SocxXfaq0PQTfK6zU0i YxE5DuK/RR1BnC3h9Hv3RWrgJWBcfjUjOfX5z+0T10V8whlb+eiHWqklzeSrugDWorhe Z4LyIVUy/1dbkE6zGCukc38dqQ2etWeXY/4TMH3O03cacklb1lO86+5698j2ztCF3Ym6 Rw+72EBYYfvM4flxyYFh08gmXUppZyD5FIDsN36aTwdkIovaOD2DFyfZDllgZwk+A5iZ 5RCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from; bh=iScPqhO9FryprXxgIMO33XxXFP01WHnZjhY7dHN8y14=; b=NJRTUGAAg1mpqkm/gFEZnOcc9ZkAkKNSzZ7Z4Cv55RSYfL34CFeo3cIqM7JdKKF3h6 Z892GY1haBIH1VK3J/p51WfLqAhYixUK09f1vRAIwApl9MCjZw0z47W+g+rMoWT9rNEi xlXkslNwd1TYrCPC3nbduwGuKWpz5cro2NYxNrxjA9b0f1w5gdIhsd9McHHo8c9V5YMi GrJ2SNawen+TBgfvj6U1qlQ2gF48HyisXxPc9xrM6tNwMUX8oeNuGwtCTBs3g2wGTE6B AczxCqwUrFP9PDZ3YNXniuhn3V0Gzs0hawLh+CyVEXNwd5KI3x1AwGCcPVosopb9jauU n9uQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e4-v6si4347508pgk.630.2018.09.13.07.06.06; Thu, 13 Sep 2018 07:06:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732188AbeIMTPS (ORCPT + 99 others); Thu, 13 Sep 2018 15:15:18 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:35514 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731789AbeIMTPR (ORCPT ); Thu, 13 Sep 2018 15:15:17 -0400 Received: from localhost (ip-213-127-77-73.ip.prioritytelecom.net [213.127.77.73]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 03CF2D39; Thu, 13 Sep 2018 14:05:36 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chris Wilson , Takashi Iwai , Pierre-Louis Bossart , =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , Joonas Lahtinen , Rodrigo Vivi Subject: [PATCH 4.18 152/197] drm/i915/lpe: Mark LPE audio runtime pm as "no callbacks" Date: Thu, 13 Sep 2018 15:31:41 +0200 Message-Id: <20180913131847.632486242@linuxfoundation.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20180913131841.568116777@linuxfoundation.org> References: <20180913131841.568116777@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chris Wilson commit 75eef0f1ed478284911b8723a5bdb659499a7aac upstream. The LPE audio is a child device of i915, it is powered up and down alongside the igfx and presents no independent runtime interface. This aptly fulfils the description of a "No-Callback" Device, so mark it thus. Fixes: 183c00350ccd ("drm/i915: Fix runtime PM for LPE audio") Testcase: igt/pm_rpm/basic-pci-d3-state Testcase: igt/pm_rpm/basic-rte Signed-off-by: Chris Wilson Cc: Takashi Iwai Cc: Pierre-Louis Bossart Cc: Ville Syrjälä Cc: stable@vger.kernel.org Reviewed-by: Joonas Lahtinen Link: https://patchwork.freedesktop.org/patch/msgid/20180802140416.6062-1-chris@chris-wilson.co.uk (cherry picked from commit 46e831abe864a6b59fa3de253a681c0f2ee1bf2f) Signed-off-by: Rodrigo Vivi Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/i915/intel_lpe_audio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/drivers/gpu/drm/i915/intel_lpe_audio.c +++ b/drivers/gpu/drm/i915/intel_lpe_audio.c @@ -127,9 +127,7 @@ lpe_audio_platdev_create(struct drm_i915 return platdev; } - pm_runtime_forbid(&platdev->dev); - pm_runtime_set_active(&platdev->dev); - pm_runtime_enable(&platdev->dev); + pm_runtime_no_callbacks(&platdev->dev); return platdev; }