Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp742700imm; Thu, 13 Sep 2018 07:07:16 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbO6dqJzb6E35/uyCywXVLyW4QAzNm51+fQNN5B1W70zM1C9gEBYXxVvUUl9LnBI6NdwJNZ X-Received: by 2002:a62:c8d2:: with SMTP id i79-v6mr7637686pfk.35.1536847636090; Thu, 13 Sep 2018 07:07:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536847636; cv=none; d=google.com; s=arc-20160816; b=tCaP+qmB8aGH08xvfo/vDgrjWZ5sDp0Px9hRXBzG8brzMUCZFun97rAefb/MJ3c6cH jDnYjCqeadgGpRrx7RVoqa60XHaaZ/hF8UnK04rCBrhCjzmEHGwbkzeYGWEtf6TCK+hp occe2mcpwd0aL1AK7Lk4frwybeLeiQI155xvw7zvimIOc5gAFNcZpacaLqF8mgVo9sNC cJNjid17RDGXG4iW0rYZrXzKY1CeTTCGrEW7jli4TAf0RS2Qf68Vlh/JNymVgG9ZB0rB x4A6VbmSM1kMlganR0Ru3UZI0cyqwsBVm5sYhgpY1LjuoNo7WAks/A471a+lP12o0XnC Rz+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from; bh=RedBuVOV/Ooz07C1uTmuWis+OSfL36fZFX6ubloITFA=; b=hxxBY84rUybCOZQiKA1WpJ3lYGilCKcmBdCfn+sP0UGYPMiem0eVtUZaG/NQfujKnA usuKsUdysoOG+riAjxTrTnHZeEqDBI85LhLIod5cw/o/UPSVYgBlF9lrvrue5iasjA+O FLkqg2kgrvUZ5BhL6N1gsuWXe/D7Am+RiCdhEvDHMcnUfLAMmknm4G+fA7Yx6zjMCae5 Bz72sIskP0TXUDAyxkm01sNB/JcuUqXajvyaEFudzOlZCqZZ49XUcKHOYwBhCxHlhvHw 9Fdp2+rlad7q9d3zjMRJDA/orNG0jgNV3nRv1pV4owxG4tOzGK2KDV+W6xzuJ8QLrziF VKaQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a140-v6si4219660pfa.61.2018.09.13.07.06.59; Thu, 13 Sep 2018 07:07:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732176AbeIMTQf (ORCPT + 99 others); Thu, 13 Sep 2018 15:16:35 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:35654 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729127AbeIMTQe (ORCPT ); Thu, 13 Sep 2018 15:16:34 -0400 Received: from localhost (ip-213-127-77-73.ip.prioritytelecom.net [213.127.77.73]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id AAA9ED36; Thu, 13 Sep 2018 14:06:54 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alex Deucher , Mike Lothian , =?UTF-8?q?Michel=20D=C3=A4nzer?= Subject: [PATCH 4.18 189/197] drm/amdgpu: Dont warn on destroying a pinned BO Date: Thu, 13 Sep 2018 15:32:18 +0200 Message-Id: <20180913131849.120083239@linuxfoundation.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20180913131841.568116777@linuxfoundation.org> References: <20180913131841.568116777@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Michel Dänzer commit 456607d816d89a442a3d5ec98b02c8bc950b5228 upstream. The warning turned out to be not so useful, as BO destruction tends to be deferred to a workqueue. Also, we should be preventing any damage from this now, so not really important anymore to fix code doing this. Acked-by: Alex Deucher Tested-by: Mike Lothian Signed-off-by: Michel Dänzer Signed-off-by: Alex Deucher Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c @@ -76,7 +76,7 @@ static void amdgpu_ttm_bo_destroy(struct struct amdgpu_device *adev = amdgpu_ttm_adev(tbo->bdev); struct amdgpu_bo *bo = ttm_to_amdgpu_bo(tbo); - if (WARN_ON_ONCE(bo->pin_count > 0)) + if (bo->pin_count > 0) amdgpu_bo_subtract_pin_size(bo); if (bo->kfd_bo)