Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 13 Sep 2018 09:04:10 -0700 (PDT)
Message-Id: <20180913.090410.1329696288697398656.davem@davemloft.net>
To:     vasilykh@arista.com
Cc:     roopa@cumulusnetworks.com, adobriyan@gmail.com,
        edumazet@google.com, stephen@networkplumber.org,
        jwestfall@surrealistic.net, w.bumiller@proxmox.com,
        anarsoul@gmail.com, keescook@chromium.org, ihrachys@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] neighbour: confirm neigh entries when ARP packet is
 received
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20180911180406.31283-1-vasilykh@arista.com>
References: <20180911180406.31283-1-vasilykh@arista.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Vasily Khoruzhick <vasilykh@arista.com>
Date: Tue, 11 Sep 2018 11:04:06 -0700

> Update 'confirmed' timestamp when ARP packet is received. It shouldn't
> affect locktime logic and anyway entry can be confirmed by any higher-layer
> protocol. Thus it makes to sense not to confirm it when ARP packet is
> received.
> 
> Fixes: 77d7123342 ("neighbour: update neigh timestamps iff update is
> effective")
> 
> Signed-off-by: Vasily Khoruzhick <vasilykh@arista.com>
> ---
> v2: - update comment to match new code.

Please fix the wording in this commit message, as per Sergei's
feedback.

Also, the Fixes: tag should be all one line (people grep for these
strings in the repository) and with no empty lines between it and the
rest of the tags such as Signed-off-by:

Thanks.