Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp141070imm; Thu, 13 Sep 2018 17:27:19 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZIa89/5IjgTdIySqv0OfNkUOD/K8UBOV4bsbYAZSBDdAosHaNWozDfSognOKL+aGTS+nwb X-Received: by 2002:a17:902:4203:: with SMTP id g3-v6mr9601141pld.30.1536884839798; Thu, 13 Sep 2018 17:27:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536884839; cv=none; d=google.com; s=arc-20160816; b=zPzSIndpOwx5ICIdZQ5RRJAx/ThirnR6wmQvsgyLhN5eukjwPjdoRqQ6Nh/s2bjpaD PAOO1kGy1YFQMGctsfGQZoKxBKKvEvXb4u4KdMKaEDZB3svlMikZBPL84YOFRBAa6Yek TIL8bJi2uraSee0iIfImVvhU5OT42/Uef6GaMKmT+FHJ1naijWnQb9YO4rmeEb8lJumQ UCU0DKg+YeDx8ySXBh7RysByfUW6yLLYFYTCwTWAtEZptpu0ydkgIQHR/0Vkeoz9eGNl CTxOG4NL0bQpBo1uhtJh+7IIdR6kR7sUhpcoUajN0pbipsasRuhhpgzg5etxM2bfrpPR XQvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:cc:references:to:subject; bh=RgtiDk/o62b1NdtHGrX7nqAuMotPoo8gmrtYCqeHicg=; b=0nueEs9ERUQIS99h7BIwXZ7fx0mvqr7ZFUTJq6BnUI9zHv2Rw6O68WU24r4H89qmtK +U8uXvMZWohLDEI05+r4e2NSzBQ7yAlWXi6iwSwTVNxLiE1uDN/L9guPoXpf15sYlg2c 2oztTqplRjQ+8E5U2F/vd8SjF5o5FAgSFBGcQJxu9dgwpofYTtSvl42oox+rYwDd6Iyd fBTfn9y0ixmRCDVraMVltE858OR7vvzmfs11mgB2lMqdFdmME0UWt7YYBaYj8sbsRxgw JsWIUpN0hQtlkoEOe+uzV47puvSytsU9oqp3LYtIqdvSeOw1hjHIMNQIDQR5enYUt4sm ZaaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f23-v6si5987295pgj.282.2018.09.13.17.27.04; Thu, 13 Sep 2018 17:27:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728267AbeINFhW (ORCPT + 99 others); Fri, 14 Sep 2018 01:37:22 -0400 Received: from mga11.intel.com ([192.55.52.93]:20575 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726873AbeINFhW (ORCPT ); Fri, 14 Sep 2018 01:37:22 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Sep 2018 17:25:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,371,1531810800"; d="scan'208";a="257100162" Received: from dhhough-mobl.amr.corp.intel.com (HELO [10.251.3.163]) ([10.251.3.163]) by orsmga005.jf.intel.com with ESMTP; 13 Sep 2018 17:25:32 -0700 Subject: Re: [PATCH V2 0/6] VA to numa node information To: Andrew Morton , prakash.sangappa@oracle.com References: <1536783844-4145-1-git-send-email-prakash.sangappa@oracle.com> <20180913084011.GC20287@dhcp22.suse.cz> <375951d0-f103-dec3-34d8-bbeb2f45f666@oracle.com> <20180913171016.55dca2453c0773fc21044972@linux-foundation.org> Cc: Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org, nao.horiguchi@gmail.com, kirill.shutemov@linux.intel.com, khandual@linux.vnet.ibm.com, steven.sistare@oracle.com From: Dave Hansen Openpgp: preference=signencrypt Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <3c77cc75-976f-1fb8-9380-cc6ab9854a26@intel.com> Date: Thu, 13 Sep 2018 17:25:32 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180913171016.55dca2453c0773fc21044972@linux-foundation.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/13/2018 05:10 PM, Andrew Morton wrote: >> Also, VMAs having THP pages can have a mix of 4k pages and hugepages. >> The page walks would be efficient in scanning and determining if it is >> a THP huge page and step over it. Whereas using the API, the application >> would not know what page size mapping is used for a given VA and so would >> have to again scan the VMA in units of 4k page size. >> >> If this sounds reasonable, I can add it to the commit / patch description. As we are judging whether this is a "good" interface, can you tell us a bit about its scalability? For instance, let's say someone has a 1TB VMA that's populated with interleaved 4k pages. How much data comes out? How long does it take to parse? Will we effectively deadlock the system if someone accidentally cat's the wrong /proc file? /proc seems like a really simple way to implement this, but it seems a *really* odd choice for something that needs to collect a large amount of data. The lseek() stuff is a nice addition, but I wonder if it's unwieldy to use in practice. For instance, if you want to read data for the VMA at 0x1000000 you lseek(fd, 0x1000000, SEEK_SET, right? You read ~20 bytes of data and then the fd is at 0x1000020. But, you're getting data out at the next read() for (at least) the next page, which is also available at 0x1001000. Seems funky. Do other /proc files behave this way?