Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262110AbTKLPwi (ORCPT ); Wed, 12 Nov 2003 10:52:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262111AbTKLPwi (ORCPT ); Wed, 12 Nov 2003 10:52:38 -0500 Received: from fw.osdl.org ([65.172.181.6]:51596 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S262110AbTKLPwh (ORCPT ); Wed, 12 Nov 2003 10:52:37 -0500 Date: Wed, 12 Nov 2003 07:52:11 -0800 (PST) From: Linus Torvalds To: Ivan Kokshaysky cc: "David S. Miller" , , , Subject: Re: 2.6.0-test9-bk16 ALi M5229 kernel boot error In-Reply-To: <20031112180642.A1064@jurassic.park.msu.ru> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1109 Lines: 26 On Wed, 12 Nov 2003, Ivan Kokshaysky wrote: > > I'm not sure there was any logic at all, given extremely misleading > comments in the original code. That "south-bridge's enable bit" stands > for "enable input pins for 80-conductor cable detection" according > to my (rather sparse) docs, and I don't understand why the hell it has > anything to do with a northbridge. The thing is, those "enable input pins" are actually GPIO's, and some boards don't use them as cable detect enables.. The whole thing should probably be done as a PCI quirk. Anyway, I'll change my patch to be the absolute minimal one, ie just adding the !isa_dev test instead of removing the old confused logic. I'm pretty certain that we shouldn't touch those GPIO's at all, but since some boards probably _do_ want them enabled, let's go for the minimal "avoid oops" approach. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/