Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp693391imm; Fri, 14 Sep 2018 05:04:04 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdbl+aFZYkIgzmHQ/d7nJfvkziV3Za0dVPoG9AXZudUeg7K8Si2F1RcF4TiQEuxikrvvGjzu X-Received: by 2002:a62:1192:: with SMTP id 18-v6mr12360716pfr.54.1536926644155; Fri, 14 Sep 2018 05:04:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536926644; cv=none; d=google.com; s=arc-20160816; b=EZre7s9OQWeMlLmFhPigz9WCBg2NaNcIulr5/I1jSN4/XaxJCbD/rP3NHrkRPbAjE0 EFAVmxwwaVLvjiqIJzjiobxQEFRXBqVuVXeCZwiJH+CfBm/cIASs2AyKqHHOMSsczF/c RmmEwGi3TddZG0Muw1fkm+OzrSAiQdYpUOiSgUlelTQijuTiEkdMQc1BxPY0vAhoNzJp rVjujLTLfEkYL4O+s3oyrJcVohupdS0LtRs7zrKvxivqe1FadcdbK1JUHp4gDRgk+BqU G/6WLwQ13M12tvW/3DboEjDDfYzd5ykU3K90bRSZ8zcVlJE0WFWDBVewPwL0+ALEcXHR jshA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=NyhqZ9CxU6ByYv7gMv8FEZ947LNll2DOGsCfpCB02nk=; b=mI6fOdEZNhlhvsBMhrn/fWa8nntOtlAYzZnlOEYh56eLHYiVysO3bOyTt1HWBGSAVW VtA6cG+aaNbf5z0zaVt7E6tq7+9b8huNPmroDMi0mokBq+fZMIyof/U0yRPa6UlGc4EW UWnvMFwS1rb5nym3Qyzp9HxD+1HHxTgfOzwkJgKueXt8SkOPGXPfBbTYZp9SOgjjDMll M/Xge54R01zU6mY5uePi5A9LX50z/opR97DeOU7+ct1k/2/FZqRo4+Tbyq0SvmEEwkM7 3E99rgG6xhXxgUw1BCW+fqNrP31PN1BJbKfCtmvP7ZWXQhBOBMoBKxUh5n4A1YcRVXYv klAw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m193-v6si7187159pfc.312.2018.09.14.05.03.46; Fri, 14 Sep 2018 05:04:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727825AbeINRRh (ORCPT + 99 others); Fri, 14 Sep 2018 13:17:37 -0400 Received: from www262.sakura.ne.jp ([202.181.97.72]:56387 "EHLO www262.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726872AbeINRRg (ORCPT ); Fri, 14 Sep 2018 13:17:36 -0400 Received: from fsav401.sakura.ne.jp (fsav401.sakura.ne.jp [133.242.250.100]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id w8EC3OHF059439; Fri, 14 Sep 2018 21:03:24 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav401.sakura.ne.jp (F-Secure/fsigk_smtp/530/fsav401.sakura.ne.jp); Fri, 14 Sep 2018 21:03:24 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/530/fsav401.sakura.ne.jp) Received: from [192.168.1.8] (softbank060157066051.bbtec.net [60.157.66.51]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id w8EC3OS6059434 (version=TLSv1.2 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 14 Sep 2018 21:03:24 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Subject: Re: [PATCH] printk: inject caller information into the body of message To: Sergey Senozhatsky Cc: Sergey Senozhatsky , Petr Mladek , Steven Rostedt , Alexander Potapenko , Dmitriy Vyukov , kbuild test robot , syzkaller , LKML , Linus Torvalds , Andrew Morton References: <20180620130628.GA1000@tigerII.localdomain> <20180912065307.GA606@jagdpanzerIV> <20180912120548.4280f04a@vmware.local.home> <20180913071204.GA604@jagdpanzerIV> <20180913122625.6ieyexpcmlc5z2it@pathway.suse.cz> <20180913142802.GB517@tigerII.localdomain> <20180914065728.GA515@jagdpanzerIV> <49d22738-17ad-410a-be0a-d27d76ba9f37@i-love.sakura.ne.jp> <20180914115028.GB20572@tigerII.localdomain> From: Tetsuo Handa Message-ID: Date: Fri, 14 Sep 2018 21:03:20 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180914115028.GB20572@tigerII.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/09/14 20:50, Sergey Senozhatsky wrote: >>> +#define DEFINE_PR_LINE_BUF(lev, name, buf, sz) \ >>> + struct pr_line name = { \ >>> + .sb = __SEQ_BUF_INITIALIZER(buf, (sz)), \ >>> + .level = lev, \ >>> + } >>> + >> >> I would use this one for the OOM killer. 80 bytes is too short. > > 80 bytes is quite short for OOM, agreed. > >> static char oom_print_buf[1024]; >> DEFINE_PR_LINE_BUF(level, oom_print_buf); > > Do I get it right that you suggest to drop the "size" param? No. I just forgot to add params. ;-) > Do OOM people agree on 1024 bytes stack usage? I won't allocate oom_print_buf on the stack. Since its usage is serialized by oom_lock mutex, we don't need to allocate from stack. Since memory allocation request might happen when stack is already tight, we should not try to allocate much from stack.