Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 14 Sep 2018 07:43:34 -0500
From:   Dimitri Sivanich <sivanich@hpe.com>
To:     "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc:     Dimitri Sivanich <sivanich@hpe.com>, Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: sgi-gru: fix fall-through annotations
Message-ID: <20180914124334.GA2205@hpe.com>
References: <20180913185317.GA1178@embeddedor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180913185317.GA1178@embeddedor.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Acked-by: Dimitri Sivanich <sivanich@hpe.com>

On Thu, Sep 13, 2018 at 01:53:18PM -0500, Gustavo A. R. Silva wrote:
> Replace "fallthru" with a proper "fall through" annotation.
> 
> This fix is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
>  drivers/misc/sgi-gru/grukservices.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/sgi-gru/grukservices.c b/drivers/misc/sgi-gru/grukservices.c
> index 0307690..4b23d58 100644
> --- a/drivers/misc/sgi-gru/grukservices.c
> +++ b/drivers/misc/sgi-gru/grukservices.c
> @@ -634,7 +634,7 @@ static int send_noop_message(void *cb, struct gru_message_queue_desc *mqd,
>  			break;
>  		case CBSS_PAGE_OVERFLOW:
>  			STAT(mesq_noop_page_overflow);
> -			/* fallthru */
> +			/* fall through */
>  		default:
>  			BUG();
>  		}
> @@ -792,7 +792,7 @@ static int send_message_failure(void *cb, struct gru_message_queue_desc *mqd,
>  		break;
>  	case CBSS_PAGE_OVERFLOW:
>  		STAT(mesq_page_overflow);
> -		/* fallthru */
> +		/* fall through */
>  	default:
>  		BUG();
>  	}
> -- 
> 2.7.4
>