Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [patch 00/11] x86/vdso: Cleanups, simmplifications and CLOCK_TAI
 support
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Andy Lutomirski <luto@kernel.org>, x86@kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Matt Rickard <matt@softrans.com.au>,
        Stephen Boyd <sboyd@kernel.org>,
        John Stultz <john.stultz@linaro.org>,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        devel@linuxdriverproject.org,
        virtualization@lists.linux-foundation.org,
        Paolo Bonzini <pbonzini@redhat.com>,
        Arnd Bergmann <arnd@arndb.de>, Juergen Gross <jgross@suse.com>
References: <20180914125006.349747096@linutronix.de>
 <2f723b28-8f81-4b02-861c-42f756a8825a@redhat.com>
 <alpine.DEB.2.21.1809141459530.10480@nanos.tec.linutronix.de>
From:   Florian Weimer <fweimer@redhat.com>
Message-ID: <63a0f67d-fdb1-e2fc-5d4d-4f3cfbf86fd1@redhat.com>
Date:   Fri, 14 Sep 2018 15:06:46 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.1809141459530.10480@nanos.tec.linutronix.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 09/14/2018 03:05 PM, Thomas Gleixner wrote:
> On Fri, 14 Sep 2018, Florian Weimer wrote:
> 
>> On 09/14/2018 02:50 PM, Thomas Gleixner wrote:
>>> Matt attempted to add CLOCK_TAI support to the VDSO clock_gettime()
>>> implementation, which extended the clockid switch case and added yet
>>> another slightly different copy of the same code.
>>>
>>> Especially the extended switch case is problematic as the compiler tends to
>>> generate a jump table which then requires to use retpolines.
>>
>> Does vDSO code really have to use retpolines?  It's in userspace, after all.
> 
> Unless you have IBRS/STIPB enabled, you need user space ratpoutine as well.

I don't think this is a consensus position, and it obviously depends on 
the (sub)architecture.

Thanks,
Florian