Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1066933imm; Fri, 14 Sep 2018 10:36:48 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZx6hu+PufxTTxHRDiFVCacpJ1lC7tZStJoyYhk62drXtkHXYsv/Smd0C2/uTKM+9aDIw06 X-Received: by 2002:a17:902:d808:: with SMTP id a8-v6mr13354811plz.68.1536946608241; Fri, 14 Sep 2018 10:36:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536946608; cv=none; d=google.com; s=arc-20160816; b=RFF4ur9Js5zpYwOGX4iAfK5mWOHBsGP52z7S6DH8PYc7MSfQ3pbc0vC+Dd/0isrdJs eguC/jF/Q+7aPhoNFz4MaI8/xaAIBJsa/KoWxFa0HWoLFYbsJXoOnT+dJ0Rqv1iPwrvY RIIgRUC8QMYOtH3K8PksWguPNbSGCz8coDMr+2FZ8VEKmJOI8d74mDX6VT2IoQIOUr9R 48tVvVA9O6/POxTnyi83S5X9CT32CytcaJIyfCXSVSrpbqLMG49XAUOh7E2TbWmNvUVQ y5DkyOHIbFM2JL5T9KOMawC+Cr4Bu1uQuFvWZhaOhxeCAi8gBJ8q2IUOuWFVvWJI9yJm Gihw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=3CBsjFqA65H4OR+nZIOhIvu6Q2NTbggCPdnPLBqmX9U=; b=Vyrj/pApp8fwPY1fP4WuutDgGw/IJbj4LWIGY5I9a4SyjX2VVOYM0JUGH+/N0HZl1l /PPiWoLuDyyw50bLwx0X52rDBFl3Ay+qA2n5eeechkL5zCEZFEzfL8qDzZSKxY2aoW34 gIVwyoSmWUpH0YV2PzSNOSUbFFNu6a3spFLIFf2olxHur+2Hyqs3prs4VeaCVi1BGHhI oZ4vM1HouVRUSbPfPHftthThz5jNj47r8rycnJtP81KMW3thDvRcGtaE75b6AINDPkQl 22esWNWv7t2uW8XdaAzySO3KGGu5b+aiEmLjhgUXYPrlcPoNrFL9eD7Yn2s8zRwgutp+ sS+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bd1-v6si7798311plb.156.2018.09.14.10.36.32; Fri, 14 Sep 2018 10:36:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728451AbeINWuG (ORCPT + 99 others); Fri, 14 Sep 2018 18:50:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28591 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727118AbeINWuF (ORCPT ); Fri, 14 Sep 2018 18:50:05 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8CD33308124C; Fri, 14 Sep 2018 17:34:36 +0000 (UTC) Received: from [10.36.116.58] (ovpn-116-58.ams2.redhat.com [10.36.116.58]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F362A65971; Fri, 14 Sep 2018 17:34:33 +0000 (UTC) Subject: Re: [PATCH v4 RESEND 4/5] x86/hyper-v: rename ipi_arg_{ex,non_ex} structures To: Vitaly Kuznetsov , kvm@vger.kernel.org Cc: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Roman Kagan , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , "Michael Kelley (EOSG)" , Wanpeng Li , linux-kernel@vger.kernel.org References: <20180822101832.31763-1-vkuznets@redhat.com> <20180822101832.31763-5-vkuznets@redhat.com> From: Paolo Bonzini Openpgp: preference=signencrypt Autocrypt: addr=pbonzini@redhat.com; prefer-encrypt=mutual; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0f UGFvbG8gQm9uemluaSA8Ym9uemluaUBnbnUub3JnPsLBTQQTAQIAIwUCVEJ7AwIbAwcLCQgH AwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEH4VEAzNNmmxNcwOniaZVLsuy1lW/ntYCA0Caz0i sHpmecK8aWlvL9wpQCk4GlOX9L1emyYXZPmzIYB0IRqmSzAlZxi+A2qm9XOxs5gJ2xqMEXX5 FMtUH3kpkWWJeLqe7z0EoQdUI4EG988uv/tdZyqjUn2XJE+K01x7r3MkUSFz/HZKZiCvYuze VlS0NTYdUt5jBXualvAwNKfxEkrxeHjxgdFHjYWhjflahY7TNRmuqPM/Lx7wAuyoDjlYNE40 Z+Kun4/KjMbjgpcF4Nf3PJQR8qXI6p3so2qsSn91tY7DFSJO6v2HwFJkC2jU95wxfNmTEUZc znXahYbVOwCDJRuPrE5GKFd/XJU9u5hNtr/uYipHij01WXal2cce1S5mn1/HuM1yo1u8xdHy IupCd57EWI948e8BlhpujUCU2tzOb2iYS0kpmJ9/oLVZrOcSZCcCl2P0AaCAsj59z2kwQS9D du0WxUs8waso0Qq6tDEHo8yLCOJDzSz4oojTtWe4zsulVnWV+wu70AioemAT8S6JOtlu60C5 dHgQUD1Tp+ReXpDKXmjbASJx4otvW0qah3o6JaqO79tbDqIvncu3tewwp6c85uZd48JnIOh3 utBAu684nJakbbvZUGikJfxd887ATQRUQnHuAQgAx4dxXO6/Zun0eVYOnr5GRl76+2UrAAem Vv9Yfn2PbDIbxXqLff7oyVJIkw4WdhQIIvvtu5zH24iYjmdfbg8iWpP7NqxUQRUZJEWbx2CR wkMHtOmzQiQ2tSLjKh/cHeyFH68xjeLcinR7jXMrHQK+UCEw6jqi1oeZzGvfmxarUmS0uRuf fAb589AJW50kkQK9VD/9QC2FJISSUDnRC0PawGSZDXhmvITJMdD4TjYrePYhSY4uuIV02v02 8TVAaYbIhxvDY0hUQE4r8ZbGRLn52bEzaIPgl1p/adKfeOUeMReg/CkyzQpmyB1TSk8lDMxQ zCYHXAzwnGi8WU9iuE1P0wARAQABwsEzBBgBAgAJBQJUQnHuAhsMAAoJEH4VEAzNNmmxp1EO oJy0uZggJm7gZKeJ7iUpeX4eqUtqelUw6gU2daz2hE/jsxsTbC/w5piHmk1H1VWDKEM4bQBT uiJ0bfo55SWsUNN+c9hhIX+Y8LEe22izK3w7mRpvGcg+/ZRG4DEMHLP6JVsv5GMpoYwYOmHn plOzCXHvmdlW0i6SrMsBDl9rw4AtIa6bRwWLim1lQ6EM3PWifPrWSUPrPcw4OLSwFk0CPqC4 HYv/7ZnASVkR5EERFF3+6iaaVi5OgBd81F1TCvCX2BEyIDRZLJNvX3TOd5FEN+lIrl26xecz 876SvcOb5SL5SKg9/rCBufdPSjojkGFWGziHiFaYhbuI2E+NfWLJtd+ZvWAAV+O0d8vFFSvr iy9enJ8kxJwhC0ECbSKFY+W1eTIhMD3aeAKY90drozWEyHhENf4l/V+Ja5vOnW+gCDQkGt2Y 1lJAPPSIqZKvHzGShdh8DduC0U3xYkfbGAUvbxeepjgzp0uEnBXfPTy09JGpgWbg0w91GyfT /ujKaGd4vxG2Ei+MMNDmS1SMx7wu0evvQ5kT9NPzyq8R2GIhVSiAd2jioGuTjX6AZCFv3ToO 53DliFMkVTecLptsXaesuUHgL9dKIfvpm+rNXRn9wAwGjk0X/A== Message-ID: <893f1078-1ea9-8a2e-0467-58f524504ac7@redhat.com> Date: Fri, 14 Sep 2018 19:34:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180822101832.31763-5-vkuznets@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Fri, 14 Sep 2018 17:34:36 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/08/2018 12:18, Vitaly Kuznetsov wrote: > These structures are going to be used from KVM code so let's make > their names reflect their Hyper-V origin. > > Signed-off-by: Vitaly Kuznetsov > Reviewed-by: Roman Kagan > --- > arch/x86/hyperv/hv_apic.c | 12 ++++++------ > arch/x86/include/asm/hyperv-tlfs.h | 16 +++++++++------- > 2 files changed, 15 insertions(+), 13 deletions(-) > > diff --git a/arch/x86/hyperv/hv_apic.c b/arch/x86/hyperv/hv_apic.c > index 402338365651..49284e1506b1 100644 > --- a/arch/x86/hyperv/hv_apic.c > +++ b/arch/x86/hyperv/hv_apic.c > @@ -93,14 +93,14 @@ static void hv_apic_eoi_write(u32 reg, u32 val) > */ > static bool __send_ipi_mask_ex(const struct cpumask *mask, int vector) > { > - struct ipi_arg_ex **arg; > - struct ipi_arg_ex *ipi_arg; > + struct hv_send_ipi_ex **arg; > + struct hv_send_ipi_ex *ipi_arg; > unsigned long flags; > int nr_bank = 0; > int ret = 1; > > local_irq_save(flags); > - arg = (struct ipi_arg_ex **)this_cpu_ptr(hyperv_pcpu_input_arg); > + arg = (struct hv_send_ipi_ex **)this_cpu_ptr(hyperv_pcpu_input_arg); > > ipi_arg = *arg; > if (unlikely(!ipi_arg)) > @@ -130,8 +130,8 @@ static bool __send_ipi_mask_ex(const struct cpumask *mask, int vector) > static bool __send_ipi_mask(const struct cpumask *mask, int vector) > { > int cur_cpu, vcpu; > - struct ipi_arg_non_ex **arg; > - struct ipi_arg_non_ex *ipi_arg; > + struct hv_send_ipi **arg; > + struct hv_send_ipi *ipi_arg; > int ret = 1; > unsigned long flags; > > @@ -148,7 +148,7 @@ static bool __send_ipi_mask(const struct cpumask *mask, int vector) > return __send_ipi_mask_ex(mask, vector); > > local_irq_save(flags); > - arg = (struct ipi_arg_non_ex **)this_cpu_ptr(hyperv_pcpu_input_arg); > + arg = (struct hv_send_ipi **)this_cpu_ptr(hyperv_pcpu_input_arg); > > ipi_arg = *arg; > if (unlikely(!ipi_arg)) > diff --git a/arch/x86/include/asm/hyperv-tlfs.h b/arch/x86/include/asm/hyperv-tlfs.h > index 08e24f552030..d0554409a3de 100644 > --- a/arch/x86/include/asm/hyperv-tlfs.h > +++ b/arch/x86/include/asm/hyperv-tlfs.h > @@ -725,19 +725,21 @@ struct hv_enlightened_vmcs { > #define HV_STIMER_AUTOENABLE (1ULL << 3) > #define HV_STIMER_SINT(config) (__u8)(((config) >> 16) & 0x0F) > > -struct ipi_arg_non_ex { > - u32 vector; > - u32 reserved; > - u64 cpu_mask; > -}; > - > struct hv_vpset { > u64 format; > u64 valid_bank_mask; > u64 bank_contents[]; > }; > > -struct ipi_arg_ex { > +/* HvCallSendSyntheticClusterIpi hypercall */ > +struct hv_send_ipi { > + u32 vector; > + u32 reserved; > + u64 cpu_mask; > +}; > + > +/* HvCallSendSyntheticClusterIpiEx hypercall */ > +struct hv_send_ipi_ex { > u32 vector; > u32 reserved; > struct hv_vpset vp_set; > This doesn't apply anymore, sorry. Paolo