Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 14 Sep 2018 18:46:31 -0500
From:   Shiraz Saleem <shiraz.saleem@intel.com>
To:     =?iso-8859-1?Q?H=E5kon?= Bugge <haakon.bugge@oracle.com>
Cc:     "Latif, Faisal" <faisal.latif@intel.com>,
        OFED mailing list <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Doug Ledford <dledford@redhat.com>,
        "Hefty, Sean" <sean.hefty@intel.com>,
        Hal Rosenstock <hal.rosenstock@gmail.com>,
        "Singhai, Anjali" <anjali.singhai@intel.com>,
        Shannon Nelson <shannon.nelson@oracle.com>
Subject: Re: mutex and rcu list traversal idiosyncrasy
Message-ID: <20180914234631.GA20084@ssaleem-MOBL4.amr.corp.intel.com>
References: <E4626316-0683-45DF-9F09-D602FC982E21@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <E4626316-0683-45DF-9F09-D602FC982E21@oracle.com>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Sep 13, 2018 at 05:55:44AM -0600, H?kon Bugge wrote:
> Hi Faisal,
> 
> 
> In commit f27b4746f378 ("i40iw: add connection management code") you have in i40iw_add_mqh_6():
> 
> rtnl_lock();
> for_each_netdev_rcu(...) {
> 	[]
> }
> rtnl_unlock();
> 
> Shouldn't this read:
> rtnl_lock();
> for_each_netdev(...) {
> 	[]
> }
> rtnl_unlock();
>

Yes.