Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1866117imm; Sat, 15 Sep 2018 04:44:06 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZWY8YfDaQKBIeHyItvlPIl9ddlJyptLITL23LZtK3K+w7SbfWQ6JDOP1YO8mo3nHKuQdw6 X-Received: by 2002:a63:d857:: with SMTP id k23-v6mr15902939pgj.106.1537011846100; Sat, 15 Sep 2018 04:44:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537011846; cv=none; d=google.com; s=arc-20160816; b=BG5ctzJmwCKjYWhgRUPuC74NpVEdfhr6l3YFIBIcjbrHncvENPBThtWpefFF4+/9kK jdbaduPDabKuyY5naKbHQt5HtpcLJqkkSXQe2IHQatG6lR3c5ufuupCEkUdHJFJPRXLN M3isxr+XIfcntYmM3B/y0jnKFz4GN6nvTkIzVDitVjbrKChvQq3eV3HQWDoeYu4m0rCf MjA71UR/lz3DR8nZRzSAV3da3SEp9NsbboMgCMLXa0Bpn9A15eNuW2MGHx5qIBwgeLJ0 4JDk2wshOaAzdluzHYaaTj7eeInAZ9LKCRk23LWctmpn2uoICncDtD9VWhH/GzEnxVnK jLig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Q+lofbH6Wu6CrEZOvMSja94j49GMr7GLWLjdon7xt4s=; b=rVJ1x1PUmdf06NW64HpHRdpB5BCHsJEsiJmk6B9jDWOF+rFikCAyyzqJXcCP4Kw9HN 1mpzfYCLsM5wIuAPOfJf1L76G6WYILdKdvIX6AbWVRJixPFSrmAzu9zsC5/gt1kQadiT 720n8kOpvrxKVE66PWC8F4SsQe96+IuDYwUY2XtGPF89u/lZFtplKI4HA5VP8W/4CQ6U sQ3mK6vQykihapwWm6ZisFKvHSC5eRTs4GTS6JGdD/bpTllQeyTHl61FTSEmiT0om5CV fh5WGCpKfs79b4ejqkD3pBw0C+A9t0FzlVsOQHEmSMaPv5YQFRJMDUwEYDG/J4DVN/YS +RZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w17-v6si10372111pfl.171.2018.09.15.04.43.49; Sat, 15 Sep 2018 04:44:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727226AbeIORC2 (ORCPT + 99 others); Sat, 15 Sep 2018 13:02:28 -0400 Received: from mail.bootlin.com ([62.4.15.54]:34135 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727009AbeIORC2 (ORCPT ); Sat, 15 Sep 2018 13:02:28 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 31BB220794; Sat, 15 Sep 2018 13:43:44 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [88.191.26.124]) by mail.bootlin.com (Postfix) with ESMTPSA id 09844206A7; Sat, 15 Sep 2018 13:43:44 +0200 (CEST) From: Alexandre Belloni To: linux-rtc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH] rtc: isl1208: avoid possible sysfs race Date: Sat, 15 Sep 2018 13:43:43 +0200 Message-Id: <20180915114343.31935-1-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.19.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use rtc_add_group to add the common sysfs group to avoid a possible race condition. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-isl1208.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c index ea18a8f4bce0..e1e9434c9972 100644 --- a/drivers/rtc/rtc-isl1208.c +++ b/drivers/rtc/rtc-isl1208.c @@ -804,7 +804,7 @@ isl1208_probe(struct i2c_client *client, const struct i2c_device_id *id) evdet_irq = of_irq_get_byname(np, "evdet"); } - rc = sysfs_create_group(&client->dev.kobj, &isl1208_rtc_sysfs_files); + rc = rtc_add_group(rtc, &isl1208_rtc_sysfs_files); if (rc) return rc; @@ -821,14 +821,6 @@ isl1208_probe(struct i2c_client *client, const struct i2c_device_id *id) return rtc_register_device(rtc); } -static int -isl1208_remove(struct i2c_client *client) -{ - sysfs_remove_group(&client->dev.kobj, &isl1208_rtc_sysfs_files); - - return 0; -} - static const struct i2c_device_id isl1208_id[] = { { "isl1208", TYPE_ISL1208 }, { "isl1218", TYPE_ISL1218 }, @@ -851,7 +843,6 @@ static struct i2c_driver isl1208_driver = { .of_match_table = of_match_ptr(isl1208_of_match), }, .probe = isl1208_probe, - .remove = isl1208_remove, .id_table = isl1208_id, }; -- 2.19.0