Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 15 Sep 2018 15:58:07 +0300
From:   Mike Rapoport <rppt@linux.vnet.ibm.com>
To:     Paul Burton <paul.burton@mips.com>
Cc:     Serge Semin <fancer.lancer@gmail.com>,
        Ralf Baechle <ralf@linux-mips.org>,
        James Hogan <jhogan@kernel.org>,
        Huacai Chen <chenhc@lemote.com>,
        Michal Hocko <mhocko@kernel.org>, linux-mips@linux-mips.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mips: switch to NO_BOOTMEM
References: <1536571398-29194-1-git-send-email-rppt@linux.vnet.ibm.com>
 <20180914195300.7wnmsph2qhpixm7s@pburton-laptop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180914195300.7wnmsph2qhpixm7s@pburton-laptop>
User-Agent: Mutt/1.5.24 (2015-08-30)
Message-Id: <20180915125806.GH15191@rapoport-lnx>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Sep 14, 2018 at 12:53:00PM -0700, Paul Burton wrote:
> Hi Mike,
> 
> On Mon, Sep 10, 2018 at 12:23:18PM +0300, Mike Rapoport wrote:
> > MIPS already has memblock support and all the memory is already registered
> > with it.
> > 
> > This patch replaces bootmem memory reservations with memblock ones and
> > removes the bootmem initialization.
> > 
> > Since memblock allocates memory in top-down mode, we ensure that memblock
> > limit is max_low_pfn to prevent allocations from the high memory.
> > 
> > To have the exceptions base in the lower 512M of the physical memory, its
> > allocation in arch/mips/kernel/traps.c::traps_init() is using bottom-up
> > mode.
> > 
> > Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com>
> > ---
> > v2:
> > * set memblock limit to max_low_pfn to avoid allocation attempts from high
> > memory
> > * use boottom-up mode for allocation of the exceptions base
> > 
> > Build tested with *_defconfig.
> > Boot tested with qemu-system-mips64el for 32r6el, 64r6el and fuloong2e
> > defconfigs.
> > Boot tested with qemu-system-mipsel for malta defconfig.
> > 
> >  arch/mips/Kconfig                      |  1 +
> >  arch/mips/kernel/setup.c               | 99 ++++++++--------------------------
> >  arch/mips/kernel/traps.c               |  3 ++
> >  arch/mips/loongson64/loongson-3/numa.c | 34 ++++++------
> >  arch/mips/sgi-ip27/ip27-memory.c       | 11 ++--
> >  5 files changed, 46 insertions(+), 102 deletions(-)
> 
> Thanks - applied to mips-next for 4.20.
> 
> Apologies for the delay, my son decided to be born a few weeks early &
> scupper my plans :)

Congratulations! :)
 
> Paul
> 

-- 
Sincerely yours,
Mike.