Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2463479imm; Sat, 15 Sep 2018 18:33:09 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdbf1l4oMQfJsFvpEPmYgWxPV1VV5VXm2uGI9DXHQvJ7/IIbPMcsy+yb0UH21+6w/lUFQHSp X-Received: by 2002:a62:464f:: with SMTP id t76-v6mr19451499pfa.118.1537061589900; Sat, 15 Sep 2018 18:33:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537061589; cv=none; d=google.com; s=arc-20160816; b=tWhJuSiqkNShFn6kwTuLqtdiBftndMu+nflBiJk/gO2qH+Ylgs5RuIRa2GgCvX3cG2 yHmcJKtAfHgHC43xRCNCbrrkayNphIAZ8MgjQ4asHr7Ee10YDZE1OKbUAPDznDhNG/dF 5FqDEc6JnZEXkcDZ5Fjmfx/7qM01o97xGm1J48p66zKrwtwXWPEVLri8RRlVBt0rO7zx p38YNIdiRdk2tq52DrcQsbjlFSNDG8M1WwZLe0yy9mgYXp19WJiW6JDaAGY2c8rwoakP y2idpneMu5B+g4EBl6fLCkr4QmNHrxdsOVHRuoWaMq0bvdV1mZB9XMT58e8WuSSt+3pK 4OuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature; bh=FYR5+faLS1P/SYG5nJyaWzRxSBh9weLOYAYN41YDGyY=; b=IuOq0ov2vFxIadwkFT8oCN4IiBaSLGhtAsJSHWvXQ6aNlIykkAJtGnqUxcMau8JIx6 i7L0c+IsJ6PN3pa4p3ehor1U5aerUC2IOcYs/ISPUpOqXbwlfxNAdkK0LYT+ct3kX1jz iiC/0to2R5ZVTuDKAeTz5DFju1vsoreyEzVumszeiO08Yu7/tnI0v9/eBrzXz0V2wU2f c/o4/BB0AFyQrSYJPSE0tT8JcLVx4QmPgkenwwvdRzTHiuo9hJvKvBf95ViZzi5zEQDh 9FHtwp0l+47xU7DOMsBxFkNJKh0NQMcU7YuUDxWNII/UL5YwI5HQWVs+SqDkEsgCJdap VcQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@thunk.org header.s=ef5046eb header.b=NBVJsb9Z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k18-v6si11388498pgl.364.2018.09.15.18.32.54; Sat, 15 Sep 2018 18:33:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@thunk.org header.s=ef5046eb header.b=NBVJsb9Z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727562AbeIPGxt (ORCPT + 99 others); Sun, 16 Sep 2018 02:53:49 -0400 Received: from imap.thunk.org ([74.207.234.97]:37010 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726198AbeIPGxs (ORCPT ); Sun, 16 Sep 2018 02:53:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FYR5+faLS1P/SYG5nJyaWzRxSBh9weLOYAYN41YDGyY=; b=NBVJsb9ZQtvKjvyHld78qXqYHB B/67xJH0Cwus7h7e9acqkFqe1ZVMzzwGjtxzgN26lOMPTYnlbmAQmXB5bseqOQyLJqo91dKqwBLab 92m6A1ZgiDtiy2OPLTXq3jEMZZqfScCLxmMwQwFslM0NDAJgbJDRENJLDLf5VA6iDuZw=; Received: from root (helo=callcc.thunk.org) by imap.thunk.org with local-esmtp (Exim 4.89) (envelope-from ) id 1g1LvN-0005jv-18; Sun, 16 Sep 2018 01:32:33 +0000 Received: by callcc.thunk.org (Postfix, from userid 15806) id 7375C7A585B; Sat, 15 Sep 2018 21:32:31 -0400 (EDT) Date: Sat, 15 Sep 2018 21:32:31 -0400 From: "Theodore Y. Ts'o" To: Toshi Kani Cc: jack@suse.cz, dan.j.williams@intel.com, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 1/3] ext4, dax: add ext4_bmap to ext4_dax_aops Message-ID: <20180916013231.GD8652@thunk.org> Mail-Followup-To: "Theodore Y. Ts'o" , Toshi Kani , jack@suse.cz, dan.j.williams@intel.com, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20180914145114.11122-1-toshi.kani@hpe.com> <20180914145114.11122-2-toshi.kani@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180914145114.11122-2-toshi.kani@hpe.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 14, 2018 at 08:51:12AM -0600, Toshi Kani wrote: > Ext4 mount path calls .bmap to the journal inode. This currently > works for the DAX mount case because ext4_iget() always set > 'ext4_da_aops' to any regular files. > > In preparation to fix ext4_iget() to set 'ext4_dax_aops' for ext4 > DAX files, add ext4_bmap() to 'ext4_dax_aops'. .bmap works for > DAX inodes. [1] > > [1]: https://lkml.org/lkml/2018/9/12/803 > Fixes: 5f0663bb4a64 ("ext4, dax: introduce ext4_dax_aops") > Signed-off-by: Toshi Kani > Suggested-by: Jan Kara > Cc: Jan Kara > Cc: Dan Williams > Cc: "Theodore Ts'o" > Cc: Andreas Dilger > Cc: Thanks, applied. - Ted