Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5B9E6F1F.5030908@huawei.com>
Date:   Sun, 16 Sep 2018 22:56:31 +0800
From:   zhong jiang <zhongjiang@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To:     Guenter Roeck <linux@roeck-us.net>
CC:     <kronos.it@gmail.com>, <jdelvare@suse.com>,
        <linux-hwmon@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hwmon: Use PTR_ERR_OR_ZERO instead of reimplementing
 its function
References: <20180916004318.GA30797@roeck-us.net>
In-Reply-To: <20180916004318.GA30797@roeck-us.net>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2018/9/16 8:43, Guenter Roeck wrote:
> On Tue, Sep 11, 2018 at 08:03:37PM +0800, zhong jiang wrote:
>> PTR_ERR_OR_ZERO has implemented the same function. We prefer to use
>> inlined function rather than code-opened implementation.
>>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> Applied to hwmon-next. For future patches, please also refer to the
> affected driver in the Subject line, unless the change is in the
> subsystem core code.
Get it.  Thanks.

Sincerely,
zhong jiang
> Thanks,
> Guenter
>
>> ---
>>  drivers/hwmon/asus_atk0110.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/hwmon/asus_atk0110.c b/drivers/hwmon/asus_atk0110.c
>> index a6636fe..a7cf008 100644
>> --- a/drivers/hwmon/asus_atk0110.c
>> +++ b/drivers/hwmon/asus_atk0110.c
>> @@ -1210,10 +1210,8 @@ static int atk_register_hwmon(struct atk_data *data)
>>  	data->hwmon_dev = hwmon_device_register_with_groups(dev, "atk0110",
>>  							    data,
>>  							    data->attr_groups);
>> -	if (IS_ERR(data->hwmon_dev))
>> -		return PTR_ERR(data->hwmon_dev);
>>  
>> -	return 0;
>> +	return PTR_ERR_OR_ZERO(data->hwmon_dev);
>>  }
>>  
>>  static int atk_probe_if(struct atk_data *data)
>> -- 
>> 1.7.12.4
>>
>