Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 16 Sep 2018 15:57:21 +0200
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Baolin Wang <baolin.wang@linaro.org>,
        Craig Tatlor <ctatlor97@gmail.com>
Cc:     robh+dt@kernel.org, mark.rutland@arm.com, linux-pm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        yuanjiang.yu@unisoc.com, broonie@kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: power: Add Spreadtrum SC27XX fuel gauge
 unit documentation
Message-ID: <20180916135721.rhu3rn4fsrmmgnbf@earth.universe>
References: <1b3f165e2a806dd3d4b7712160ee3bda72f7d675.1536736399.git.baolin.wang@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="d2rtcggg5cqwck6e"
Content-Disposition: inline
In-Reply-To: <1b3f165e2a806dd3d4b7712160ee3bda72f7d675.1536736399.git.baolin.wang@linaro.org>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--d2rtcggg5cqwck6e
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, Sep 12, 2018 at 03:29:38PM +0800, Baolin Wang wrote:
> This patch adds the binding documentation for Spreadtrum SC27XX series PM=
ICs
> fuel gauge unit device, which is used to calculate the battery capacity.
>=20
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> ---
>  .../devicetree/bindings/power/supply/sc27xx-fg.txt |   55 ++++++++++++++=
++++++
>  1 file changed, 55 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/supply/sc27xx=
-fg.txt
>=20
> diff --git a/Documentation/devicetree/bindings/power/supply/sc27xx-fg.txt=
 b/Documentation/devicetree/bindings/power/supply/sc27xx-fg.txt
> new file mode 100644
> index 0000000..7447bae
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/sc27xx-fg.txt
> @@ -0,0 +1,55 @@
> +Spreadtrum SC27XX PMICs Fuel Gauge Unit Power Supply Bindings
> +
> +Required properties:
> +- compatible: Should be one of the following:
> +  "sprd,sc2720-fgu",
> +  "sprd,sc2721-fgu",
> +  "sprd,sc2723-fgu",
> +  "sprd,sc2730-fgu",
> +  "sprd,sc2731-fgu".
> +- reg: The address offset of fuel gauge unit.
> +- bat-detect-gpio: GPIO for battery detection.
> +- io-channels: Specify the IIO ADC channel to get temperature.
> +- io-channel-names: Should be "bat-temp".
> +- sprd,inner-resist: Specify the the battery inner resistance (mOhm).

This should be a property of the battery.without the sprd, prefix.

> +- sprd,ocv-cap-table: Provide the battery capacity percent with correspo=
nding
> +  open circuit voltage (ocv) of the battery, which is used to look up cu=
rrent
> +  battery capacity according to current baterry ocv values.

This should also be part of the battery binding. I just reviewed a
patchset for the Qualcomm Battery Monitoring System, which needs the
same functionality. The Qualcomm binding is more advanced, but
should also support this simpler case. Thus I think it makes sense
to use its description as base for adding support for this feature
to Documentation/devicetree/bindings/power/supply/battery.txt

-- Sebastian

> +- monitored-battery: Phandle of battery characteristics devicetree node.
> +  The fuel gauge uses the following battery properties:
> +- charge-full-design-microamp-hours: battery design capacity.
> +- constant-charge-voltage-max-microvolt: maximum constant input voltage.
> +  See Documentation/devicetree/bindings/power/supply/battery.txt
> +
> +Example:
> +
> +	bat: battery {
> +		compatible =3D "simple-battery";
> +		charge-full-design-microamp-hours =3D <1900000>;
> +		constant-charge-voltage-max-microvolt =3D <4350000>;
> +		......
> +	};
> +
> +	sc2731_pmic: pmic@0 {
> +		compatible =3D "sprd,sc2731";
> +		reg =3D <0>;
> +		spi-max-frequency =3D <26000000>;
> +		interrupts =3D <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
> +		interrupt-controller;
> +		#interrupt-cells =3D <2>;
> +		#address-cells =3D <1>;
> +		#size-cells =3D <0>;
> +
> +		fgu@a00 {
> +			compatible =3D "sprd,sc2731-fgu";
> +			reg =3D <0xa00>;
> +			bat-detect-gpio =3D <&pmic_eic 9 GPIO_ACTIVE_HIGH>;
> +			io-channels =3D <&pmic_adc 5>;
> +			io-channel-names =3D "bat-temp";
> +			sprd,inner-resist =3D <250>;
> +			sprd,ocv-cap-table =3D <4185 100>, <4113 95>, <4066 90>, <4022 85>, <=
3983 80>, <3949 75>, <3917 70>,
> +				<3889 65>, <3864 60>, <3835 55>, <3805 50>, <3787 45>, <3777 40>, <3=
773 35>, <3770 30>,
> +				<3765 25>, <3752 20>, <3724 15>, <3680 10>, <3605 5>, <3400 0>;
> +			monitored-battery =3D <&bat>;
> +		};
> +	};
> --=20
> 1.7.9.5
>=20

--d2rtcggg5cqwck6e
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAlueYUEACgkQ2O7X88g7
+prBpA/+L4vfCccaNDqookIw9lLx8g654kCwWqFEMlyu6kGJ5NxPKW7bp5pgYbLr
IFjWqntkQg816WJUYz1Bz7eV3XJYTn7uSufIKz5pee5f45RZsa5NcNHOSqWDaBka
kgbJZSs3tQDksaIv1wTQWH18T/mE2rpoIszvtnrbIBUDL9QDqwLQXhXHJKsq9e0S
SgIMAFMIwZ9sP9HN1hn4NHj5SUv0ZHNR5JK1wL9WWpvWxfYuGd6Zz+Ekz2x6IZvh
aMTkcngN9eV/DfPUagBZZmiAYrMTQ4JrOeHj1AQWuZra0/6/D+zVg/ES093JN0LH
F8u7jB7X0b5V0MPSFDmDsSXgrPLLki/upHl79oDLEjTBtq6TyU30/dU1MJN3lo0R
nkCgiHe3uscelpWVkSDRxk806CpPUNPFxh6VcXLY01JCEPyAaDiU/Y2qC4+e3Gvn
3Y0Xg3SiakKCEnkPbpxJ0xco8QsCR4ErGu5qWQUVNALD1XLAaCUapTIiSgd0IBIk
4Hlq4Hi24m1Ox42B0sPrh55BRgyfICW5pllnPqPkhTS9z1qvBaYlhO8B1GMmuqSH
FtUTPc9QriOHGICK6W9bWs93NO2hw+jnx0Su3s05+RRR6nO9MujLIWrETIA22fC0
CFZNDdopuVuTrCnqhu3jD8T4AcP/WLkZpuCeYjJFmdUjhXxYGCM=
=qeQf
-----END PGP SIGNATURE-----

--d2rtcggg5cqwck6e--